Register mixin use from modelz.

Register mixin use from modelz.

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/681c3e6a89a0d8f1dca1987c65fb3bffd9a8aef5

[Johnni Winther, 2016-05-10 09:26:32]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2016-05-10 17:17:48]

lgtm

https://codereview.chromium.org/1961323002/diff/1/tests/compiler/dart2js/seri...
File tests/compiler/dart2js/serialization/model_test.dart (right):

https://codereview.chromium.org/1961323002/diff/1/tests/compiler/dart2js/seri...
tests/compiler/dart2js/serialization/model_test.dart:178: onClasses(a.cls,
b.cls);
nit: the `onClasses` callback argument feels like "this is extra stuff that is
not required to check the equivalence of class hierarchy nodes."

To make it clear that this is a core part of the checks, I would pass in the
compilers here and call checkMixinUses directly. If you prefer to keep the
compiler arguments outside this function, then consider making `onClasses`
mandatory and rename it to something else that highlights it is not really
optional, maybe `checkMixins`?

[Johnni Winther, 2016-05-11 07:53:11]

https://codereview.chromium.org/1961323002/diff/1/tests/compiler/dart2js/seri...
File tests/compiler/dart2js/serialization/model_test.dart (right):

https://codereview.chromium.org/1961323002/diff/1/tests/compiler/dart2js/seri...
tests/compiler/dart2js/serialization/model_test.dart:178: onClasses(a.cls,
b.cls);
On 2016/05/10 17:17:48, Siggi Cherem (dart-lang) wrote:
> nit: the `onClasses` callback argument feels like "this is extra stuff that is
> not required to check the equivalence of class hierarchy nodes."
> 
> To make it clear that this is a core part of the checks, I would pass in the
> compilers here and call checkMixinUses directly. If you prefer to keep the
> compiler arguments outside this function, then consider making `onClasses`
> mandatory and rename it to something else that highlights it is not really
> optional, maybe `checkMixins`?

Done.

[Johnni Winther, 2016-05-11 07:53:12]

https://codereview.chromium.org/1961323002/diff/1/tests/compiler/dart2js/seri...
File tests/compiler/dart2js/serialization/model_test.dart (right):

https://codereview.chromium.org/1961323002/diff/1/tests/compiler/dart2js/seri...
tests/compiler/dart2js/serialization/model_test.dart:178: onClasses(a.cls,
b.cls);
On 2016/05/10 17:17:48, Siggi Cherem (dart-lang) wrote:
> nit: the `onClasses` callback argument feels like "this is extra stuff that is
> not required to check the equivalence of class hierarchy nodes."
> 
> To make it clear that this is a core part of the checks, I would pass in the
> compilers here and call checkMixinUses directly. If you prefer to keep the
> compiler arguments outside this function, then consider making `onClasses`
> mandatory and rename it to something else that highlights it is not really
> optional, maybe `checkMixins`?

Done.

[Johnni Winther, 2016-05-11 07:53:48]

Description was changed from

==========
Register mixin use from modelz.
==========

to

==========
Register mixin use from modelz.

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/681c3e6a89a0d8f1dca1987c65fb3bffd9a8aef5
==========

[Johnni Winther, 2016-05-11 07:53:50]

Committed patchset #2 (id:20001) manually as
681c3e6a89a0d8f1dca1987c65fb3bffd9a8aef5 (presubmit successful).