Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Unified Diff: chrome/browser/android/shortcut_info.cc

Issue 1961313002: Cache web app data for home screen sites declaring "display": "fullscreen" in their manifest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing nits Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/android/shortcut_helper.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/shortcut_info.cc
diff --git a/chrome/browser/android/shortcut_info.cc b/chrome/browser/android/shortcut_info.cc
index bb19d64d3a839288ad2efd05bd3ac07502b104cf..cadec49f4dbc9a148caa01c7d869fd0a708c1396 100644
--- a/chrome/browser/android/shortcut_info.cc
+++ b/chrome/browser/android/shortcut_info.cc
@@ -40,10 +40,8 @@ void ShortcutInfo::UpdateFromManifest(const content::Manifest& manifest) {
if (manifest.display != blink::WebDisplayModeUndefined)
display = manifest.display;
- // 'fullscreen' and 'minimal-ui' are not yet supported, fallback to the right
- // mode in those cases.
- if (manifest.display == blink::WebDisplayModeFullscreen)
- display = blink::WebDisplayModeStandalone;
+ // 'minimal-ui' is not yet supported, so fallback in this case.
+ // See crbug.com/604390.
if (manifest.display == blink::WebDisplayModeMinimalUi)
display = blink::WebDisplayModeBrowser;
« no previous file with comments | « chrome/browser/android/shortcut_helper.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698