chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java - Issue 1961313002: Cache web app data for home screen sites declaring "display": "fullscreen" in their manifest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java

Issue 1961313002: Cache web app data for home screen sites declaring "display": "fullscreen" in their manifest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing nits Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappDataStorage.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java

index 5015d888fa7ce26a7e20e0779b7bff08c6bc66f1..6e7f57cd7dcf0ee80e5f835631165c77c086c353 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java

@@ -102,6 +102,8 @@ public class WebappActivity extends FullScreenActivity {

mWebappInfo = newWebappInfo;

resetSavedInstanceState();

if (mIsInitialized) initializeUI(null);

+ // TODO(dominickn): send the web app into fullscreen if mDisplayMode is

+ // WebDisplayMode.Fullscreen. See crbug.com/581522

}

@@ -119,6 +121,8 @@ public class WebappActivity extends FullScreenActivity {

getActivityTab().addObserver(createTabObserver());

getActivityTab().getTabWebContentsDelegateAndroid().setDisplayMode(

WebDisplayMode.Standalone);

+ // TODO(dominickn): send the web app into fullscreen if mDisplayMode is

+ // WebDisplayMode.Fullscreen. See crbug.com/581522

}

@Override