Issue 19613: Merge 8764 - Add support for UA spoofing, and spoof Safari's UA string when l...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19613: Merge 8764 - Add support for UA spoofing, and spoof Safari's UA string when l... (Closed)

Created:
11 years, 11 months ago by laforge

Modified:
9 years, 7 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/branches/release_154.next/src/

Visibility:
Public.

Description

Merge 8764 - Add support for UA spoofing, and spoof Safari's UA string when loading URLs from *.mail.live.com (to fix hotmail). BUG=4111 R=wtc Review URL: http://codereview.chromium.org/19025 TBR=darin Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=8781

Patch Set 1 #

Total comments: 1

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+66 lines, -38 lines)			Patch
M	chrome/browser/browser_about_handler.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/profile.cc	View	3 chunks	+5 lines, -3 lines	1 comment	Download
M	net/url_request/url_request_context.h	View	2 chunks	+13 lines, -12 lines	0 comments	Download
M	net/url_request/url_request_http_job.cc	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	net/url_request/url_request_inet_job.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	webkit/glue/plugins/plugin_host.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/glue/webframeloaderclient_impl.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	webkit/glue/webkit_glue.h	View	1 chunk	+4 lines, -3 lines	0 comments	Download
M	webkit/glue/webkit_glue.cc	View	4 chunks	+28 lines, -11 lines	0 comments	Download
M	webkit/tools/test_shell/test_shell_request_context.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	webkit/tools/test_shell/test_shell_request_context.cc	View	2 chunks	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

darin (slow to review)

11 years, 11 months ago (2009-01-28 09:15:01 UTC) #2

LGTM

http://codereview.chromium.org/19613/diff/1/11
File chrome/browser/profile.cc (right):

http://codereview.chromium.org/19613/diff/1/11#newcode157
Line 157: const std::string& GetUserAgent(
nit: the line break here should probably be removed.

Expand Messages | Collapse Messages