Issue 196128: Hook up WebViewClient, part 1....

Issue 196128: Hook up WebViewClient, part 1.... (Closed)

Created:
11 years, 3 months ago by darin (slow to review)

Modified:
9 years, 7 months ago

Reviewers:
dglazkov

CC:
chromium-reviews_googlegroups.com, John Grabowski, darin (slow to review), brettw, pam+watch_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Hook up WebViewClient, part 1. This change makes WebViewDelegate extend from WebViewClient as a temporary means to start having consumers implement and use WebViewClient. R=dglazkov BUG=10033 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26355

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+678 lines, -745 lines)			Patch
M	chrome/renderer/print_web_view_helper.h	View		2 chunks	+40 lines, -2 lines	0 comments	Download
M	chrome/renderer/print_web_view_helper.cc	View	1	3 chunks	+9 lines, -8 lines	0 comments	Download
M	chrome/renderer/print_web_view_helper_win.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/renderer/render_view.h	View	1 2 3	7 chunks	+36 lines, -43 lines	0 comments	Download
M	chrome/renderer/render_view.cc	View	1	17 chunks	+227 lines, -214 lines	0 comments	Download
M	webkit/api/public/WebViewClient.h	View		5 chunks	+42 lines, -45 lines	0 comments	Download
M	webkit/glue/back_forward_list_client_impl.cc	View		2 chunks	+6 lines, -6 lines	0 comments	Download
M	webkit/glue/chrome_client_impl.cc	View		10 chunks	+66 lines, -82 lines	0 comments	Download
M	webkit/glue/dragclient_impl.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	webkit/glue/webframeloaderclient_impl.cc	View		5 chunks	+14 lines, -21 lines	0 comments	Download
M	webkit/glue/webview_delegate.h	View		8 chunks	+3 lines, -149 lines	0 comments	Download
M	webkit/glue/webview_impl.h	View		2 chunks	+7 lines, -1 line	0 comments	Download
M	webkit/glue/webview_impl.cc	View		3 chunks	+8 lines, -7 lines	0 comments	Download
M	webkit/tools/test_shell/layout_test_controller.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	webkit/tools/test_shell/layout_test_controller.cc	View		7 chunks	+14 lines, -10 lines	0 comments	Download
M	webkit/tools/test_shell/mac/test_webview_delegate.mm	View		3 chunks	+16 lines, -15 lines	0 comments	Download
M	webkit/tools/test_shell/test_shell.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	webkit/tools/test_shell/test_shell.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/tools/test_shell/test_shell_gtk.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/tools/test_shell/test_shell_mac.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/tools/test_shell/test_shell_win.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/tools/test_shell/test_webview_delegate.h	View		4 chunks	+36 lines, -36 lines	0 comments	Download
M	webkit/tools/test_shell/test_webview_delegate.cc	View	1 2	7 chunks	+114 lines, -85 lines	0 comments	Download
M	webkit/tools/test_shell/test_webview_delegate_gtk.cc	View	1 2	3 chunks	+16 lines, -8 lines	0 comments	Download
M	webkit/tools/test_shell/test_webview_delegate_win.cc	View		2 chunks	+11 lines, -3 lines	0 comments	Download
M	webkit/webkit.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM.

Expand Messages | Collapse Messages