Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 1961223004: webkitpy: Remove unused _run_command_with_teed_output (Closed)

Created:
4 years, 7 months ago by mithro
Modified:
4 years, 7 months ago
Reviewers:
Dirk Pranke, jam, qyearsley
CC:
blink-reviews, chromium-reviews, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

webkitpy: Remove unused _run_command_with_teed_output This function appears to be unused and it also uses subprocess in an unsafe manner (see http://crbug.com/610613). BUG=610618 R=jam@chromium.org,qyearsley@chromium.org,dpranke@chromium.org Committed: https://crrev.com/141b51fc2b3a3e6ce3cc4566c42bd20a30b86c21 Cr-Commit-Position: refs/heads/master@{#392735}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -20 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive.py View 1 chunk +0 lines, -20 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
mithro
Hi everyone, I can't seem to find any users of this code. Please send to ...
4 years, 7 months ago (2016-05-10 10:37:08 UTC) #2
Dirk Pranke
yeah, it wouldn't surprise me if this was dead code. lgtm.
4 years, 7 months ago (2016-05-10 20:55:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1961223004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1961223004/1
4 years, 7 months ago (2016-05-10 20:56:25 UTC) #5
qyearsley
Also LGTM
4 years, 7 months ago (2016-05-10 20:59:49 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-10 21:55:22 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-10 21:56:26 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/141b51fc2b3a3e6ce3cc4566c42bd20a30b86c21
Cr-Commit-Position: refs/heads/master@{#392735}

Powered by Google App Engine
This is Rietveld 408576698