Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(900)

Issue 1961223002: [Media Router WebUI] Run 'select cast mode' test in afterNextRender(); (Closed)

Created:
4 years, 7 months ago by apacible
Modified:
4 years, 7 months ago
Reviewers:
imcheng
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Media Router WebUI] Run 'select cast mode' test in afterNextRender(); There's a race condition where afterNextRender() is not always called before setTimeout(). 'select cast mode' appears to be the only failing test right now, so this changes runs the test within afterNextRender(). However, all of the tests (especially if it relies on the listeners) should be run in afterNextRender() to ensure setup is complete. Further work will be done specifically for Media Router WebUI tests to reflect this. BUG=609411 Committed: https://crrev.com/7c783d41c599ec59ac8cfca1f4163404bfbf2693 Cr-Commit-Position: refs/heads/master@{#392516}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M chrome/test/data/webui/media_router/media_router_container_cast_mode_list_tests.js View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
apacible
PTAL, thanks! Initial change to turn bots green. I'll be digging into the test runners ...
4 years, 7 months ago (2016-05-09 23:58:04 UTC) #3
imcheng
lgtm
4 years, 7 months ago (2016-05-10 00:18:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1961223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1961223002/1
4 years, 7 months ago (2016-05-10 00:29:46 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-10 02:07:15 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-10 02:09:00 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7c783d41c599ec59ac8cfca1f4163404bfbf2693
Cr-Commit-Position: refs/heads/master@{#392516}

Powered by Google App Engine
This is Rietveld 408576698