chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.h - Issue 1961183002: MD Settings: Update some Settings handlers to use new JS lifecycle management.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.h

Issue 1961183002: MD Settings: Update some Settings handlers to use new JS lifecycle management. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/webui/settings/chromeos/device_keyboard_handler.h ('K') | « chrome/browser/ui/webui/settings/chromeos/device_keyboard_handler.cc ('k') | chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.h

diff --git a/chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.h b/chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.h

index 5663d058060543f15942e61bcb837d65b3c98ecb..4a7c66d186c45eb54aa573fea6d9e8b89a23ef19 100644

--- a/chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.h

+++ b/chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.h

@@ -7,6 +7,7 @@

#include "base/macros.h"

#include "base/memory/scoped_vector.h"

+#include "base/scoped_observer.h"

#include "chrome/browser/browsing_data/browsing_data_remover.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/ui/webui/settings/settings_page_ui_handler.h"

@@ -64,6 +65,8 @@ class ClearBrowsingDataHandler : public SettingsPageUIHandler,

// ProfileSyncService to observe sync state changes.

ProfileSyncService* sync_service_;

+ ScopedObserver<ProfileSyncService, sync_driver::SyncServiceObserver>

+ sync_service_observer_;

// If non-null it means removal is in progress.

BrowsingDataRemover* remover_;