Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 1961173004: Drop unnecessary uses of GarbageCollectedFinalized<>. (Closed)

Created:
4 years, 7 months ago by sof
Modified:
4 years, 7 months ago
Reviewers:
haraken, bajones
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Drop unnecessary uses of GarbageCollectedFinalized<>. Objects with Member<> fields can derive from the non-finalized GarbageCollected<> instead. R= BUG=389343 Committed: https://crrev.com/1eebce0ad9bd68449a86e1ac8303083bb22ed65e Cr-Commit-Position: refs/heads/master@{#392641}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M third_party/WebKit/Source/modules/vr/VREyeParameters.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/vr/VRPose.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/vr/VRStageParameters.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
sof
please take a look.
4 years, 7 months ago (2016-05-10 15:28:30 UTC) #3
bajones
On 2016/05/10 15:28:30, sof wrote: > please take a look. LGTM
4 years, 7 months ago (2016-05-10 15:38:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1961173004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1961173004/1
4 years, 7 months ago (2016-05-10 15:49:03 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-10 17:52:11 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1eebce0ad9bd68449a86e1ac8303083bb22ed65e Cr-Commit-Position: refs/heads/master@{#392641}
4 years, 7 months ago (2016-05-10 17:53:32 UTC) #10
haraken
4 years, 7 months ago (2016-05-10 23:25:31 UTC) #11
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698