Corrected assert for cacheable stylesheets.

Corrected assert for cacheable stylesheets.

We have two different caches for StyleSheetContents. One process-wide
for resources, and one document-wide for parsed text of style elements.
The cacheability differ between the two caches since for instance
sheets with @media rules may be shared between elements in the same
document as the media query evaluation will be the same, while we can't
do that for sheets cached across documents as they may have different
viewports.

The assert in CSSStyleSheet::willMutateRules triggered because we
checked for the resource cacheability of a style element sheet which
was shared even though it had a media query. Renamed the cacheability
method to make clear which cache we're referring to.

Removed the ASSERT in StyleSheetContents::copy(), as that really didn't
have anything to do with copy, only the fact that it is only called
from where cached stylesheets are cloned for rule mutation. The ASSERT
in willMutateRules right before we copy() should suffice.

R=timloh@chromium.org
BUG=551674
Committed: https://crrev.com/4bdb01c415930156cb26eb368fff57de4b3ee250
Cr-Commit-Position: refs/heads/master@{#392859}

[rune, 2016-05-10 12:13:33]

The CQ bit was checked by rune@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-05-10 12:13:43]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1961173003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1961173003/1

[rune, 2016-05-10 12:13:46]

ptal

[commit-bot: I haz the power, 2016-05-10 15:59:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-10 15:59:09]

Dry run: This issue passed the CQ dry run.

[Timothy Loh, 2016-05-11 04:37:36]

On 2016/05/10 12:13:46, rune wrote:
> ptal

lgtm

[Timothy Loh, 2016-05-11 04:37:37]

On 2016/05/10 12:13:46, rune wrote:
> ptal

lgtm

[rune, 2016-05-11 05:12:13]

The CQ bit was checked by rune@opera.com

[commit-bot: I haz the power, 2016-05-11 05:12:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1961173003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1961173003/1

[commit-bot: I haz the power, 2016-05-11 05:15:55]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-11 05:17:08]

Description was changed from

==========
Corrected assert for cacheable stylesheets.

We have two different caches for StyleSheetContents. One process-wide
for resources, and one document-wide for parsed text of style elements.
The cacheability differ between the two caches since for instance
sheets with @media rules may be shared between elements in the same
document as the media query evaluation will be the same, while we can't
do that for sheets cached across documents as they may have different
viewports.

The assert in CSSStyleSheet::willMutateRules triggered because we
checked for the resource cacheability of a style element sheet which
was shared even though it had a media query. Renamed the cacheability
method to make clear which cache we're referring to.

Removed the ASSERT in StyleSheetContents::copy(), as that really didn't
have anything to do with copy, only the fact that it is only called
from where cached stylesheets are cloned for rule mutation. The ASSERT
in willMutateRules right before we copy() should suffice.

R=timloh@chromium.org
BUG=551674
==========

to

==========
Corrected assert for cacheable stylesheets.

We have two different caches for StyleSheetContents. One process-wide
for resources, and one document-wide for parsed text of style elements.
The cacheability differ between the two caches since for instance
sheets with @media rules may be shared between elements in the same
document as the media query evaluation will be the same, while we can't
do that for sheets cached across documents as they may have different
viewports.

The assert in CSSStyleSheet::willMutateRules triggered because we
checked for the resource cacheability of a style element sheet which
was shared even though it had a media query. Renamed the cacheability
method to make clear which cache we're referring to.

Removed the ASSERT in StyleSheetContents::copy(), as that really didn't
have anything to do with copy, only the fact that it is only called
from where cached stylesheets are cloned for rule mutation. The ASSERT
in willMutateRules right before we copy() should suffice.

R=timloh@chromium.org
BUG=551674

Committed: https://crrev.com/4bdb01c415930156cb26eb368fff57de4b3ee250
Cr-Commit-Position: refs/heads/master@{#392859}
==========

[commit-bot: I haz the power, 2016-05-11 05:17:09]

Patchset 1 (id:??) landed as
https://crrev.com/4bdb01c415930156cb26eb368fff57de4b3ee250
Cr-Commit-Position: refs/heads/master@{#392859}