Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1961173002: Remove invalid pinch-zoom assert in top_controls_manager (Closed)

Created:
4 years, 7 months ago by majidvp
Modified:
4 years, 7 months ago
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove invalid pinch-zoom assert in top_controls_manager It is possible to receive Scroll{Begin,End} while handling a pinch zoom. For example this can occur when receiving input from multiple different sources (e.g., a touchscreen pinch zoom and a touchpad scroll). The logic is changed to ignore any scrolls during an active pinch gesture instead of asserting. BUG=600364 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/b85b6a8846c06a6095ff5f04946541e39b41dddc Cr-Commit-Position: refs/heads/master@{#392531}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M cc/input/top_controls_manager.cc View 1 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
majidvp
4 years, 7 months ago (2016-05-09 21:34:42 UTC) #4
aelias_OOO_until_Jul13
lgtm
4 years, 7 months ago (2016-05-09 22:41:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1961173002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1961173002/20001
4 years, 7 months ago (2016-05-10 02:14:54 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-10 02:56:30 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-10 02:57:34 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b85b6a8846c06a6095ff5f04946541e39b41dddc
Cr-Commit-Position: refs/heads/master@{#392531}

Powered by Google App Engine
This is Rietveld 408576698