Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1100)

Issue 1961163002: Linux: Remove SSE2 check at startup. (Closed)

Created:
4 years, 7 months ago by Lei Zhang
Modified:
4 years, 7 months ago
Reviewers:
Nico
CC:
chromium-reviews, grt+watch_chromium.org, Michael Moss, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Linux: Remove SSE2 check at startup. Google Chrome for Linux is 64-bit only now. All amd64 processors should support SSE2. This effectively reverts r271529. Committed: https://crrev.com/f0ec52e845cb35991816f971d92e6961cd1b96ef Cr-Commit-Position: refs/heads/master@{#393614}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -19 lines) Patch
M chrome/installer/linux/common/wrapper View 1 chunk +0 lines, -19 lines 1 comment Download

Messages

Total messages: 11 (5 generated)
Lei Zhang
4 years, 7 months ago (2016-05-09 21:23:02 UTC) #3
Nico
lgtm, but: https://codereview.chromium.org/1961163002/diff/1/chrome/installer/linux/common/wrapper File chrome/installer/linux/common/wrapper (left): https://codereview.chromium.org/1961163002/diff/1/chrome/installer/linux/common/wrapper#oldcode26 chrome/installer/linux/common/wrapper:26: echo "$SSE2_DEPRECATION_MSG" 1>&2 should we have a ...
4 years, 7 months ago (2016-05-09 21:29:37 UTC) #4
Lei Zhang
On 2016/05/09 21:29:37, Nico wrote: > lgtm, but: > > https://codereview.chromium.org/1961163002/diff/1/chrome/installer/linux/common/wrapper > File chrome/installer/linux/common/wrapper (left): ...
4 years, 7 months ago (2016-05-09 21:39:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1961163002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1961163002/1
4 years, 7 months ago (2016-05-13 19:21:02 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-13 20:33:44 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-13 20:35:16 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f0ec52e845cb35991816f971d92e6961cd1b96ef
Cr-Commit-Position: refs/heads/master@{#393614}

Powered by Google App Engine
This is Rietveld 408576698