Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 196113002: Fix possible use of garbage value in acquirePaintingResource (Closed)

Created:
6 years, 9 months ago by Mostyn Bramley-Moore
Modified:
6 years, 9 months ago
Reviewers:
Timothy Loh, eae
CC:
blink-reviews, krit, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, fs, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, pdr., kouhei+svg_chromium.org, Stephen Chennney, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Fix possible use of garbage value in acquirePaintingResource If ASSERT_NOT_REACHED is compiled out (like in release builds), then hasFallback can be used uninitialized below. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169000

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/core/rendering/svg/SVGInlineTextBox.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
Mostyn Bramley-Moore
PTAL...
6 years, 9 months ago (2014-03-11 23:08:00 UTC) #1
eae
Seems reasonable. Is there a bug or test for this?
6 years, 9 months ago (2014-03-11 23:13:58 UTC) #2
Mostyn Bramley-Moore
No bug that I know of- I found this while testing static analyzer tools.
6 years, 9 months ago (2014-03-11 23:16:42 UTC) #3
eae
On 2014/03/11 23:16:42, Mostyn Bramley-Moore wrote: > No bug that I know of- I found ...
6 years, 9 months ago (2014-03-11 23:18:54 UTC) #4
Mostyn Bramley-Moore
The CQ bit was checked by mostynb@opera.com
6 years, 9 months ago (2014-03-11 23:19:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mostynb@opera.com/196113002/1
6 years, 9 months ago (2014-03-11 23:20:01 UTC) #6
Timothy Loh
On 2014/03/11 23:16:42, Mostyn Bramley-Moore wrote: > No bug that I know of- I found ...
6 years, 9 months ago (2014-03-11 23:35:38 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-12 03:13:25 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel
6 years, 9 months ago (2014-03-12 03:13:25 UTC) #9
Mostyn Bramley-Moore
The CQ bit was checked by mostynb@opera.com
6 years, 9 months ago (2014-03-12 08:24:53 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mostynb@opera.com/196113002/1
6 years, 9 months ago (2014-03-12 08:25:03 UTC) #11
commit-bot: I haz the power
6 years, 9 months ago (2014-03-12 09:37:56 UTC) #12
Message was sent while issue was closed.
Change committed as 169000

Powered by Google App Engine
This is Rietveld 408576698