Break apart shared use of varying and uniform transforms

Break apart shared use of varying and uniform transforms

This is a pre-cl for: https://codereview.chromium.org/1955893002/

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1961093002

Committed: https://skia.googlesource.com/skia/+/fe8a8392217072fdd5505edc3876a9698608ada1

[egdaniel, 2016-05-09 16:31:57]

Description was changed from

==========
Break apart shared use of varying and uniform transforms

This is a pre-cl for: https://codereview.chromium.org/1955893002/

BUG=skia:
==========

to

==========
Break apart shared use of varying and uniform transforms

This is a pre-cl for: https://codereview.chromium.org/1955893002/

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[egdaniel, 2016-05-09 16:35:19]

egdaniel@google.com changed reviewers:
+ bsalomon@google.com, robertphillips@google.com

[egdaniel, 2016-05-09 16:35:20]

This change will make it possible to have uniform and varying handles be
distinct objects in the follow on CL

[robertphillips, 2016-05-09 16:51:29]

lgtm

https://codereview.chromium.org/1961093002/diff/1/src/gpu/GrPathProcessor.cpp
File src/gpu/GrPathProcessor.cpp (right):

https://codereview.chromium.org/1961093002/diff/1/src/gpu/GrPathProcessor.cpp...
src/gpu/GrPathProcessor.cpp:119: typedef GrGLSLProgramDataManager::VaryingHandle
VaryingHandle;
init fHandle here ?

https://codereview.chromium.org/1961093002/diff/1/src/gpu/glsl/GrGLSLGeometry...
File src/gpu/glsl/GrGLSLGeometryProcessor.h (right):

https://codereview.chromium.org/1961093002/diff/1/src/gpu/glsl/GrGLSLGeometry...
src/gpu/glsl/GrGLSLGeometryProcessor.h:116: 
init fHandle here?

[robertphillips, 2016-05-09 16:51:30]

lgtm

[egdaniel, 2016-05-09 16:58:59]

The CQ bit was checked by egdaniel@google.com

[egdaniel, 2016-05-09 16:59:06]

https://codereview.chromium.org/1961093002/diff/1/src/gpu/GrPathProcessor.cpp
File src/gpu/GrPathProcessor.cpp (right):

https://codereview.chromium.org/1961093002/diff/1/src/gpu/GrPathProcessor.cpp...
src/gpu/GrPathProcessor.cpp:119: typedef GrGLSLProgramDataManager::VaryingHandle
VaryingHandle;
On 2016/05/09 16:51:28, robertphillips wrote:
> init fHandle here ?

The default ctor of a ResourceHandle sets the handle to invalid, so it should be
doing what we want as it.

[commit-bot: I haz the power, 2016-05-09 16:59:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1961093002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1961093002/1

[commit-bot: I haz the power, 2016-05-09 17:22:24]

Description was changed from

==========
Break apart shared use of varying and uniform transforms

This is a pre-cl for: https://codereview.chromium.org/1955893002/

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Break apart shared use of varying and uniform transforms

This is a pre-cl for: https://codereview.chromium.org/1955893002/

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/fe8a8392217072fdd5505edc3876a9698608ada1
==========

[commit-bot: I haz the power, 2016-05-09 17:22:24]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/fe8a8392217072fdd5505edc3876a9698608ada1