Issue 196109: Load the http auth dialog from the main bundle....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 196109: Load the http auth dialog from the main bundle.... (Closed)

Created:
11 years, 3 months ago by TVL

Modified:
9 years, 7 months ago

Reviewers:
pink (ping after 24hrs), Nico

CC:
chromium-reviews_googlegroups.com, John Grabowski, pam+watch_chromium.org, Ben Goodger (Google)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Load the http auth dialog from the main bundle. Localize the http auth dialog. Add the explanation to the http auth dialog. Autosize the http auth dialog after putting in the explanation. TEST=http auto ui should now be localized. BUG=20532 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26140

Patch Set 1 #

Total comments: 2

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1002 lines, -197 lines)			Patch
M	chrome/app/nibs/HttpAuthLoginSheet.xib	View	15 chunks	+973 lines, -195 lines	0 comments	Download
MM	chrome/browser/login_prompt_mac.h	View	2 chunks	+2 lines, -0 lines	0 comments	Download
MM	chrome/browser/login_prompt_mac.mm	View	4 chunks	+26 lines, -2 lines	2 comments	Download
M	chrome/chrome.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

pink (ping after 24hrs)

lgtm with nit. http://codereview.chromium.org/196109/diff/1/3 File chrome/browser/login_prompt_mac.mm (right): http://codereview.chromium.org/196109/diff/1/3#newcode356 Line 356: // Put in the text ...

11 years, 3 months ago (2009-09-14 19:08:11 UTC) #2

Nico

11 years, 3 months ago (2009-09-14 19:34:56 UTC) #3

LG.

http://codereview.chromium.org/196109/diff/1/3
File chrome/browser/login_prompt_mac.mm (right):

http://codereview.chromium.org/196109/diff/1/3#newcode368
Line 368: rect.size.height = rect.size.height + explanationShift;
+=

Expand Messages | Collapse Messages