third_party/WebKit/Source/platform/graphics/filters/SourceGraphic.h - Issue 1961083006: Don't store an SkPicture in the SourceGraphic FilterEffect

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/filters/SourceGraphic.h

Issue 1961083006: Don't store an SkPicture in the SourceGraphic FilterEffect (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Drop clearResult call in addAbsolutePaintRect Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/graphics/filters/FilterEffect.cpp ('K') | « third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.cpp ('k') | third_party/WebKit/Source/platform/graphics/filters/SourceGraphic.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/filters/SourceGraphic.h

diff --git a/third_party/WebKit/Source/platform/graphics/filters/SourceGraphic.h b/third_party/WebKit/Source/platform/graphics/filters/SourceGraphic.h

index 63dd82d9585e15e85ba22bcc89a2ae12a9758f08..07491abf48ac309137a6a4c322b68a3331f007f1 100644

--- a/third_party/WebKit/Source/platform/graphics/filters/SourceGraphic.h

+++ b/third_party/WebKit/Source/platform/graphics/filters/SourceGraphic.h

@@ -25,8 +25,6 @@

#include "platform/geometry/IntRect.h"

#include "platform/graphics/filters/FilterEffect.h"

-class SkPicture;

namespace blink {

class PLATFORM_EXPORT SourceGraphic final : public FilterEffect {

@@ -39,15 +37,12 @@ public:

FilterEffectType getFilterEffectType() const override { return FilterEffectTypeSourceInput; }

TextStream& externalRepresentation(TextStream&, int indention) const override;

- sk_sp<SkImageFilter> createImageFilter() override;

- void setPicture(sk_sp<SkPicture>);

void setSourceRect(const IntRect&);

private:

explicit SourceGraphic(Filter*);

- sk_sp<SkPicture> m_picture;

IntRect m_sourceRect;

};