third_party/WebKit/Source/core/paint/SVGFilterPainter.cpp - Issue 1961083006: Don't store an SkPicture in the SourceGraphic FilterEffect

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/SVGFilterPainter.cpp

Issue 1961083006: Don't store an SkPicture in the SourceGraphic FilterEffect (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Drop clearResult call in addAbsolutePaintRect Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/graphics/filters/FilterEffect.cpp » ('j') | third_party/WebKit/Source/platform/graphics/filters/FilterEffect.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/SVGFilterPainter.cpp

diff --git a/third_party/WebKit/Source/core/paint/SVGFilterPainter.cpp b/third_party/WebKit/Source/core/paint/SVGFilterPainter.cpp

index b09a59a43cb3e834a1510143befc4a0c559a3190..852431671124d183ac90ad595fe529ab56c05d06 100644

--- a/third_party/WebKit/Source/core/paint/SVGFilterPainter.cpp

+++ b/third_party/WebKit/Source/core/paint/SVGFilterPainter.cpp

@@ -48,7 +48,7 @@ void SVGFilterRecordingContext::endContent(FilterData* filterData)

m_paintController->commitNewDisplayItems();

m_paintController->paintArtifact().replay(*context);

- sourceGraphic->setPicture(toSkSp(context->endRecording()));

+ SkiaImageFilterBuilder::buildSourceGraphic(sourceGraphic, toSkSp(context->endRecording()));

// Content is cached by the source graphic so temporaries can be freed.

m_paintController = nullptr;