Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issue 1961083004: Fix Georgian font selection on Windows 7 (Closed)

Created:
4 years, 7 months ago by eae
Modified:
4 years, 7 months ago
Reviewers:
drott
CC:
blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, kinuko+watch, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix Georgian font selection on Windows 7 Change FontFallbackWin to specify Sylfaen before Segoe UI for Georgian. The Segoe UI font is present on Windows 7 and therefore matches despite not having the required glyphs for Georgian. BUG=606196 TBR=drott@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/c1300bcc9f5d724be1f08bf4d0ec3f3ca2cbe531

Patch Set 1 #

Patch Set 2 : w/TestExpectations #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/win/FontFallbackWin.cpp View 1 2 chunks +1 line, -2 lines 2 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1961083004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1961083004/1
4 years, 7 months ago (2016-05-09 19:05:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1961083004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1961083004/20001
4 years, 7 months ago (2016-05-09 20:34:29 UTC) #4
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/c1300bcc9f5d724be1f08bf4d0ec3f3ca2cbe531 Cr-Commit-Position: refs/heads/master@{#392452}
4 years, 7 months ago (2016-05-09 22:44:10 UTC) #6
eae
Committed patchset #2 (id:20001) manually as c1300bcc9f5d724be1f08bf4d0ec3f3ca2cbe531 (presubmit successful).
4 years, 7 months ago (2016-05-09 22:45:58 UTC) #8
drott
https://codereview.chromium.org/1961083004/diff/20001/third_party/WebKit/Source/platform/fonts/win/FontFallbackWin.cpp File third_party/WebKit/Source/platform/fonts/win/FontFallbackWin.cpp (left): https://codereview.chromium.org/1961083004/diff/20001/third_party/WebKit/Source/platform/fonts/win/FontFallbackWin.cpp#oldcode416 third_party/WebKit/Source/platform/fonts/win/FontFallbackWin.cpp:416: case UBLOCK_RUNIC: Why was this removed? Did it conflict ...
4 years, 7 months ago (2016-05-11 06:05:31 UTC) #9
eae
https://codereview.chromium.org/1961083004/diff/20001/third_party/WebKit/Source/platform/fonts/win/FontFallbackWin.cpp File third_party/WebKit/Source/platform/fonts/win/FontFallbackWin.cpp (left): https://codereview.chromium.org/1961083004/diff/20001/third_party/WebKit/Source/platform/fonts/win/FontFallbackWin.cpp#oldcode416 third_party/WebKit/Source/platform/fonts/win/FontFallbackWin.cpp:416: case UBLOCK_RUNIC: On 2016/05/11 06:05:31, drott wrote: > Why ...
4 years, 7 months ago (2016-05-11 16:07:27 UTC) #10
drott
4 years, 7 months ago (2016-05-12 07:08:48 UTC) #11
Message was sent while issue was closed.
Weird, anyway, doesn't show up in the commit, so LGTM.

Powered by Google App Engine
This is Rietveld 408576698