Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: chrome/browser/android/offline_pages/prerendering_loader.h

Issue 1961083002: Updates to PrerenderingOffliner and PrerenderingLoader interfaces to push PrerenderManager knowledge (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed the unnecessary const on enum accessor as it made a trybot unhappy. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/android/offline_pages/prerendering_loader.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/offline_pages/prerendering_loader.h
diff --git a/chrome/browser/android/offline_pages/prerendering_loader.h b/chrome/browser/android/offline_pages/prerendering_loader.h
index c83c2770fa582bca502324ed078691baa6c96d94..f4af6a2b7a2e0b37892acaf3ec965e59df8f1a2e 100644
--- a/chrome/browser/android/offline_pages/prerendering_loader.h
+++ b/chrome/browser/android/offline_pages/prerendering_loader.h
@@ -9,9 +9,9 @@
#include "components/offline_pages/background/offliner.h"
class GURL;
-class PrerenderManager;
namespace content {
+class BrowserContext;
class WebContents;
class SessionStorageNamespace;
} // namespace content
@@ -31,24 +31,21 @@ class PrerenderingLoader {
content::WebContents*)>
LoadPageCallback;
- explicit PrerenderingLoader(PrerenderManager* prerender_manager);
- ~PrerenderingLoader();
+ explicit PrerenderingLoader(content::BrowserContext* browser_context);
+ virtual ~PrerenderingLoader();
// Loads a page in the background if possible and returns whether the
// request was accepted. If so, the LoadPageCallback will be informed
// of status. Only one load request may exist as a time. If a previous
// request is still in progress it must be canceled before a new
// request will be accepted.
- bool LoadPage(const GURL& url,
- content::SessionStorageNamespace* session_storage_namespace,
- const gfx::Size& size,
- const LoadPageCallback& callback);
+ virtual bool LoadPage(const GURL& url, const LoadPageCallback& callback);
// Stops (completes or cancels) the load request. Must be called when
// LoadPageCallback is done with consuming the contents.
// This loader should also be responsible for stopping offline
// prerenders when Chrome is transitioned to foreground.
- void StopLoading();
+ virtual void StopLoading();
};
} // namespace offline_pages
« no previous file with comments | « no previous file | chrome/browser/android/offline_pages/prerendering_loader.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698