chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java - Issue 1961073002: Add the snippet header back into the code and show the snippet header when the user scrolls the sni…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java

Issue 1961073002: Add the snippet header back into the code and show the snippet header when the user scrolls the sni… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java ('k') | chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java

index 57b908102cd1a135446c2ba46ee14481b70884d9..4048be5cddb9a19c98e00fda7e0cfad87b7b5782 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java

@@ -121,10 +121,7 @@ public class NewTabPageAdapter extends Adapter<NewTabPageViewHolder> implements

mNewTabPageListItems.clear();

mNewTabPageListItems.add(mAboveTheFoldListItem);

- // TODO(https://crbug.com/608918): Remove this for now as we need to come up with a better

- // way to visibly not affect the layout of the page when not shown as currently pixels are

- // allocated even though visibility is set to GONE.

- // mNewTabPageListItems.add(new SnippetHeaderListItem());

+ mNewTabPageListItems.add(new SnippetHeaderListItem());

mNewTabPageListItems.addAll(listSnippets);

notifyDataSetChanged();