Add support for per-isolate private symbols

src/symbol.js

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 45 matching lines @@
 
 function SymbolValueOf() {
   if (!(IS_SYMBOL(this) || IS_SYMBOL_WRAPPER(this))) {
     throw MakeTypeError(
       'incompatible_method_receiver', ["Symbol.prototype.valueOf", this]);
   }
   return %_ValueOf(this);
 }
 
 
-function GetSymbolRegistry() {
-  var registry = %SymbolRegistry();
-  if (!('internal' in registry)) {
-    registry.internal = {__proto__: null};
-    registry.for = {__proto__: null};
-    registry.keyFor = {__proto__: null};
-  }
-  return registry;
-}
-
-
 function InternalSymbol(key) {
-  var registry = GetSymbolRegistry();
-  if (!(key in registry.internal)) {
-    registry.internal[key] = %CreateSymbol(key);
-  }
-  return registry.internal[key];
+  var registry = %SymbolRegistry().for_intern;

[Michael Starzinger, 2014/03/24 15:17:19]

nit: The usage of the local variable "registry" is different here and below,
this is a little bit confusing IMHO.

[rossberg, 2014/03/24 15:54:46]

Done.

+  if (IS_UNDEFINED(registry[key])) registry[key] = %CreateSymbol(key);
+  return registry[key];
 }
 
 
 function SymbolFor(key) {
   key = TO_STRING_INLINE(key);
-  var registry = GetSymbolRegistry();
-  if (!(key in registry.for)) {
+  var registry = %SymbolRegistry();
+  if (IS_UNDEFINED(registry.for[key])) {
     var symbol = %CreateSymbol(key);
     registry.for[key] = symbol;
     registry.keyFor[symbol] = key;
   }
   return registry.for[key];
 }
 
 
 function SymbolKeyFor(symbol) {
-  if (!IS_SYMBOL(symbol)) {
-    throw MakeTypeError("not_a_symbol", [symbol]);
-  }
-  return GetSymbolRegistry().keyFor[symbol];
+  if (!IS_SYMBOL(symbol)) throw MakeTypeError("not_a_symbol", [symbol]);
+  return %SymbolRegistry().keyFor[symbol];
 }
 
 
 // ES6 19.1.2.8
 function ObjectGetOwnPropertySymbols(obj) {
   if (!IS_SPEC_OBJECT(obj)) {
     throw MakeTypeError("called_on_non_object",
                         ["Object.getOwnPropertySymbols"]);
   }
 
@@ skipping 47 matching lines @@
 
 function ExtendObject() {
   %CheckIsBootstrapping();
 
   InstallFunctions($Object, DONT_ENUM, $Array(
     "getOwnPropertySymbols", ObjectGetOwnPropertySymbols
   ));
 }
 
 ExtendObject();