Add support for per-isolate private symbols

include/v8.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 1980 matching lines @@
 /**
  * A JavaScript symbol (ECMA-262 edition 6)
  *
  * This is an experimental feature. Use at your own risk.
  */
 class V8_EXPORT Symbol : public Primitive {
  public:
   // Returns the print name string of the symbol, or undefined if none.
   Local<Value> Name() const;
 
   // Create a symbol. If data is not NULL, it will be used as a print name.

[Michael Starzinger, 2014/03/24 10:04:33]

nit: Comment is outdated.

[rossberg, 2014/03/24 15:09:49]

Done.

   static Local<Symbol> New(
-      Isolate *isolate, const char* data = NULL, int length = -1);
+      Isolate *isolate, Local<String> name = Local<String>());
+
+  // TODO(rossberg): Add For method (and Global?).
 
   V8_INLINE static Symbol* Cast(v8::Value* obj);
  private:
   Symbol();
   static void CheckCast(v8::Value* obj);
 };
 
 
 /**
  * A private symbol
  *
  * This is an experimental feature. Use at your own risk.
  */
 class V8_EXPORT Private : public Data {
  public:
   // Returns the print name string of the private symbol, or undefined if none.
   Local<Value> Name() const;
 
   // Create a private symbol. If data is not NULL, it will be the print name.

[Michael Starzinger, 2014/03/24 10:04:33]

nit: Likewise.

[rossberg, 2014/03/24 15:09:49]

Done.

-  static Local<Private> New(Isolate *isolate,
-                            Local<String> name = Local<String>());
+  static Local<Private> New(
+      Isolate *isolate, Local<String> name = Local<String>());
+
+  // Retrieve a global private symbol. If a symbol with this name has not
+  // been retrieved in the same isolate before, it is created.
+  // Note that private symbols created this way are never collected, so
+  // they should only be used for statically fixed properties.
+  // Also, there is only one global name space for the names used as keys.
+  // To minimize the potential for clashed, use qualified names as keys,
+  // e.g., "Class#property".
+  static Local<Private> Global(Isolate *isolate, Local<String> name);

[Michael Starzinger, 2014/03/24 10:04:33]

Using this name there is the risk that it gets confused with the "global object"
and Context::Global() specifically.

[rossberg, 2014/03/24 15:09:49]

Renamed to ForApi. Also added Symbol::For and Symbol::ForApi.

 
  private:
   Private();
 };
 
 
 /**
  * A JavaScript number value (ECMA-262, 4.3.20)
  */
 class V8_EXPORT Number : public Primitive {
@@ skipping 4576 matching lines @@
  */
 
 
 }  // namespace v8
 
 
 #undef TYPE_CHECK
 
 
 #endif  // V8_H_