Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(666)

Unified Diff: pkg/analyzer/lib/src/summary/resynthesize.dart

Issue 1960933002: Fix AST summarization of synthetic function types and method tear-offs. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/summary/link.dart ('k') | pkg/analyzer/test/src/summary/resynthesize_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/summary/resynthesize.dart
diff --git a/pkg/analyzer/lib/src/summary/resynthesize.dart b/pkg/analyzer/lib/src/summary/resynthesize.dart
index f037804d591b7142cee2990333f1cf6edfd1bc3c..e6ac50d7a5f8eaad703f43ab662cc4d17cf1252d 100644
--- a/pkg/analyzer/lib/src/summary/resynthesize.dart
+++ b/pkg/analyzer/lib/src/summary/resynthesize.dart
@@ -2149,13 +2149,20 @@ class _UnitResynthesizer {
FunctionElementImpl parameterTypeElement =
new FunctionElementImpl('', -1);
parameterTypeElement.synthetic = true;
- parameterElement.parameters =
- serializedParameter.parameters.map(buildParameter).toList();
- parameterTypeElement.enclosingElement = parameterElement;
- parameterTypeElement.shareParameters(parameterElement.parameters);
+ List<ParameterElement> subParameters = serializedParameter.parameters
+ .map((UnlinkedParam p) => buildParameter(p, synthetic: synthetic))
+ .toList();
+ if (synthetic) {
+ parameterTypeElement.parameters = subParameters;
+ } else {
+ parameterElement.parameters = subParameters;
+ parameterTypeElement.shareParameters(subParameters);
+ parameterTypeElement.enclosingElement = parameterElement;
+ }
parameterTypeElement.returnType = buildType(serializedParameter.type);
parameterElement.type = new FunctionTypeImpl.elementWithNameAndArgs(
parameterTypeElement, null, getCurrentTypeArguments(), false);
+ parameterTypeElement.type = parameterElement.type;
} else {
if (serializedParameter.isInitializingFormal &&
serializedParameter.type == null) {
« no previous file with comments | « pkg/analyzer/lib/src/summary/link.dart ('k') | pkg/analyzer/test/src/summary/resynthesize_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698