Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(719)

Issue 1960903002: [Extensions] Clean and update runtime bindings (Closed)

Created:
4 years, 7 months ago by Devlin
Modified:
4 years, 7 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Clean and update runtime bindings BUG=591164 BUG=609286 Committed: https://crrev.com/c7ce4fc66d9d3a2811306edbd9e69f2355efb62c Cr-Commit-Position: refs/heads/master@{#392512}

Patch Set 1 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -81 lines) Patch
M extensions/renderer/resources/binding.js View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/renderer/resources/runtime_custom_bindings.js View 5 chunks +22 lines, -49 lines 1 comment Download
M extensions/renderer/runtime_custom_bindings.cc View 6 chunks +27 lines, -32 lines 0 comments Download

Messages

Total messages: 21 (13 generated)
Devlin
4 years, 7 months ago (2016-05-08 17:16:05 UTC) #9
robwu
lgtm https://codereview.chromium.org/1960903002/diff/100001/extensions/renderer/resources/runtime_custom_bindings.js File extensions/renderer/resources/runtime_custom_bindings.js (left): https://codereview.chromium.org/1960903002/diff/100001/extensions/renderer/resources/runtime_custom_bindings.js#oldcode152 extensions/renderer/resources/runtime_custom_bindings.js:152: }); Nice. Removing this unnecessary logic improves the ...
4 years, 7 months ago (2016-05-08 18:06:50 UTC) #10
asargent_no_longer_on_chrome
lgtm
4 years, 7 months ago (2016-05-09 23:20:21 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1960903002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1960903002/100001
4 years, 7 months ago (2016-05-10 00:16:11 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chromium_gn_compile_dbg/builds/63690) cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 7 months ago (2016-05-10 01:05:19 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1960903002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1960903002/100001
4 years, 7 months ago (2016-05-10 01:16:32 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:100001)
4 years, 7 months ago (2016-05-10 01:41:49 UTC) #19
commit-bot: I haz the power
4 years, 7 months ago (2016-05-10 01:42:59 UTC) #21
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c7ce4fc66d9d3a2811306edbd9e69f2355efb62c
Cr-Commit-Position: refs/heads/master@{#392512}

Powered by Google App Engine
This is Rietveld 408576698