Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1960863002: [ChromiumPerf] Disable failing android benchmarks on ChromiumPerf (Closed)

Created:
4 years, 7 months ago by fmeawad
Modified:
4 years, 7 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ChromiumPerf] Disable failing android benchmarks on ChromiumPerf BUG=605120, 610015, 610018, 610019, 610021 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq Committed: https://crrev.com/fd1d68375707e9dbfd7a5804b879828778e9276f Cr-Commit-Position: refs/heads/master@{#392255}

Patch Set 1 #

Total comments: 3

Patch Set 2 : "all" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M tools/perf/benchmarks/rasterize_and_record_micro.py View 1 chunk +2 lines, -1 line 0 comments Download
M tools/perf/benchmarks/smoothness.py View 1 2 chunks +5 lines, -1 line 0 comments Download
M tools/perf/benchmarks/webrtc.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
fmeawad
PTAL
4 years, 7 months ago (2016-05-07 00:05:46 UTC) #3
nednguyen
lgtm https://codereview.chromium.org/1960863002/diff/1/tools/perf/benchmarks/smoothness.py File tools/perf/benchmarks/smoothness.py (right): https://codereview.chromium.org/1960863002/diff/1/tools/perf/benchmarks/smoothness.py#newcode327 tools/perf/benchmarks/smoothness.py:327: @benchmark.Disabled @benchmark.Disabled('all') I think
4 years, 7 months ago (2016-05-07 00:10:22 UTC) #4
aiolos (Not reviewing)
lgtm https://codereview.chromium.org/1960863002/diff/1/tools/perf/benchmarks/smoothness.py File tools/perf/benchmarks/smoothness.py (right): https://codereview.chromium.org/1960863002/diff/1/tools/perf/benchmarks/smoothness.py#newcode327 tools/perf/benchmarks/smoothness.py:327: @benchmark.Disabled On 2016/05/07 00:10:22, nednguyen wrote: > @benchmark.Disabled('all') ...
4 years, 7 months ago (2016-05-07 01:05:06 UTC) #5
fmeawad
https://codereview.chromium.org/1960863002/diff/1/tools/perf/benchmarks/smoothness.py File tools/perf/benchmarks/smoothness.py (right): https://codereview.chromium.org/1960863002/diff/1/tools/perf/benchmarks/smoothness.py#newcode327 tools/perf/benchmarks/smoothness.py:327: @benchmark.Disabled On 2016/05/07 01:05:06, aiolos(slow reviews) wrote: > On ...
4 years, 7 months ago (2016-05-07 01:43:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1960863002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1960863002/20001
4 years, 7 months ago (2016-05-07 01:44:25 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_s5_perf_cq on tryserver.chromium.perf (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.perf/builders/android_s5_perf_cq/builds/194)
4 years, 7 months ago (2016-05-07 09:51:27 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1960863002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1960863002/20001
4 years, 7 months ago (2016-05-07 12:40:28 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-07 12:44:28 UTC) #16
commit-bot: I haz the power
4 years, 7 months ago (2016-05-07 12:46:01 UTC) #18
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/fd1d68375707e9dbfd7a5804b879828778e9276f
Cr-Commit-Position: refs/heads/master@{#392255}

Powered by Google App Engine
This is Rietveld 408576698