Initial CL for Web APKs

Initial CL for Web APKs

Web APKs is a proposal to improve homescreen shortcuts by:
- Giving them a spot in the app launcher
- Enabling web pages to open a Web APK when a user taps on a URL which belongs
  to a Web APK

This CL introduces a new APK target - "webapk". The APK's Android manifest can
be customized to launch different websites as a homescreen shortcut

BUG=609122
Committed: https://crrev.com/2dd67964a3f0c7fb7cdf91bd5291e85625978d92
Cr-Commit-Position: refs/heads/master@{#392486}

[pkotwicz, 2016-05-06 23:31:12]

pkotwicz@chromium.org changed reviewers:
+ yfriedman@chromium.org

[pkotwicz, 2016-05-06 23:31:13]

Yaron can you please take a look?

Who else should I get to review this CL. I suspect that we need sign off to add
a new toplevel directory

[pkotwicz, 2016-05-06 23:35:51]

Patchset #1 (id:1) has been deleted

[Yaron, 2016-05-09 13:25:51]

yfriedman@chromium.org changed reviewers:
+ jam@chromium.org

[Yaron, 2016-05-09 13:25:52]

lgtm

+jam for new top level directory

https://codereview.chromium.org/1960853002/diff/20001/webapk/shell_apk/Androi...
File webapk/shell_apk/AndroidManifest.xml (right):

https://codereview.chromium.org/1960853002/diff/20001/webapk/shell_apk/Androi...
webapk/shell_apk/AndroidManifest.xml:17: android:label="mintingapp"
WebApk Sample App

[jam, 2016-05-09 16:25:16]

On 2016/05/09 13:25:52, Yaron wrote:
> lgtm
> 
> +jam for new top level directory

Why is this a new top level directory? It seems like as a feature of Chrome, it
can go under src/chrome/browser somewhere?

[pkotwicz, 2016-05-09 17:05:57]

I added a new toplevel directory because this introduces a target ("webapk")
which generates a new APK (as opposed to something that Chrome's APK uses). This
new APK sends an intent which launches Chrome. The code that I added cannot
depend on anything in Chrome including //base/

[pkotwicz, 2016-05-09 17:11:31]

Description was changed from

==========
Initial CL for Web APKs

Web APKs is a proposal to improve homescreen shortcuts by:
- Giving them a spot in the app launcher
- Enabling web pages to open a Web APK when a user taps on a URL which belongs
  to a Web APK

This CL introduces a new APK target - "webapk". The APK's Android manifest can
be customized to launch different websites as a homescreen shortcut

BUG=609122
==========

to

==========
Initial CL for Web APKs

Web APKs is a proposal to improve homescreen shortcuts by:
- Giving them a spot in the app launcher
- Enabling web pages to open a Web APK when a user taps on a URL which belongs
  to a Web APK

This CL introduces a new APK target - "webapk". The APK's Android manifest can
be customized to launch different websites as a homescreen shortcut

BUG=609122
==========

[jam, 2016-05-09 17:13:29]

On 2016/05/09 17:05:57, pkotwicz wrote:
> I added a new toplevel directory because this introduces a target ("webapk")
> which generates a new APK (as opposed to something that Chrome's APK uses).

To point to other examples: src/chrome already generates many targets (e.g. on
Windows chrome.exe, chrome.dll, chrome_child.dll, and also installer etc...). So
it's fine to have another target in src/chrome

> This
> new APK sends an intent which launches Chrome. The code that I added cannot
> depend on anything in Chrome including //base/

That can be enforced with DEPS rules.

[Yaron, 2016-05-09 17:14:31]

On 2016/05/09 17:05:57, pkotwicz wrote:
> I added a new toplevel directory because this introduces a target ("webapk")
> which generates a new APK (as opposed to something that Chrome's APK uses).
This
> new APK sends an intent which launches Chrome. The code that I added cannot
> depend on anything in Chrome including //base/

To expand on Peter's point - we've been trying to do some work to keep this both
componentized and isolated from Chrome. This means we have:
- a reference app (included here) which doesn't depend on chrome
- a runtime library (coming soon) - meant to be dynamically loaded by the webapk
(also not depending on chrome)
- a client library - code to be used to interact with webapks (e.g. chrome)
- chrome integration & customization of the client library - this will live in
chrome/browser

There are more READMEs coming as we bring up the other pieces. The overall plan
was lgtm'd but not directory structure so let us know if we should adjust

[jam, 2016-05-09 17:18:56]

On 2016/05/09 17:14:31, Yaron wrote:
> On 2016/05/09 17:05:57, pkotwicz wrote:
> > I added a new toplevel directory because this introduces a target ("webapk")
> > which generates a new APK (as opposed to something that Chrome's APK uses).
> This
> > new APK sends an intent which launches Chrome. The code that I added cannot
> > depend on anything in Chrome including //base/
> 
> To expand on Peter's point - we've been trying to do some work to keep this
both
> componentized and isolated from Chrome. This means we have:
> - a reference app (included here) which doesn't depend on chrome
> - a runtime library (coming soon) - meant to be dynamically loaded by the
webapk
> (also not depending on chrome)
> - a client library - code to be used to interact with webapks (e.g. chrome)
> - chrome integration & customization of the client library - this will live in
> chrome/browser
> 
> There are more READMEs coming as we bring up the other pieces. The overall
plan
> was lgtm'd but not directory structure so let us know if we should adjust

All the above seems good, and possible to do in a subdir of chrome. Just trying
to avoid a proliferation of top level directories unless absolutely needed, and
it seems that this use case can be handled as a subdirectory unless I'm missing
something.

[pkotwicz, 2016-05-09 17:25:53]

jam@: Would you prefer it if this code lives in //components/webapk ?

[jam, 2016-05-09 17:31:17]

On 2016/05/09 17:25:53, pkotwicz wrote:
> jam@: Would you prefer it if this code lives in //components/webapk ?

What would be the advantage of putting it in src/components compared to
src/chrome if the only caller is src/chrome?

[pkotwicz, 2016-05-09 17:43:51]

Chrome does not use the code in the webapk directory except via IPC. The code is
isolated from Chrome.

The "webapk" APK:
- sends Android intents to Chrome
- provides a bound service which Chrome connects to via IPC

[jam, 2016-05-09 18:05:23]

On 2016/05/09 17:43:51, pkotwicz wrote:
> Chrome does not use the code in the webapk directory except via IPC. The code
is
> isolated from Chrome.

ok.. This sounds like the chrome/service too btw.

> 
> The "webapk" APK:
> - sends Android intents to Chrome
> - provides a bound service which Chrome connects to via IPC

How about chrome/android/webapk?

[pkotwicz, 2016-05-09 18:37:45]

jam@ can you please take another look?

Ok moved to chrome/android/webapk

[jam, 2016-05-09 20:09:05]

lgtm

[pkotwicz, 2016-05-09 20:09:46]

The CQ bit was checked by pkotwicz@chromium.org

[pkotwicz, 2016-05-09 20:09:46]

The patchset sent to the CQ was uploaded after l-g-t-m from
yfriedman@chromium.org
Link to the patchset: https://codereview.chromium.org/1960853002/#ps60001
(title: "Addressed Yaron's comment in #5")

[commit-bot: I haz the power, 2016-05-09 20:10:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1960853002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1960853002/60001

[commit-bot: I haz the power, 2016-05-09 20:55:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-09 20:55:21]

Try jobs failed on following builders:
  android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[pkotwicz, 2016-05-09 22:55:10]

The CQ bit was checked by pkotwicz@chromium.org

[pkotwicz, 2016-05-09 22:55:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
yfriedman@chromium.org, jam@chromium.org
Link to the patchset: https://codereview.chromium.org/1960853002/#ps80001
(title: " ")

[commit-bot: I haz the power, 2016-05-09 22:55:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1960853002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1960853002/80001

[commit-bot: I haz the power, 2016-05-10 00:21:23]

Description was changed from

==========
Initial CL for Web APKs

Web APKs is a proposal to improve homescreen shortcuts by:
- Giving them a spot in the app launcher
- Enabling web pages to open a Web APK when a user taps on a URL which belongs
  to a Web APK

This CL introduces a new APK target - "webapk". The APK's Android manifest can
be customized to launch different websites as a homescreen shortcut

BUG=609122
==========

to

==========
Initial CL for Web APKs

Web APKs is a proposal to improve homescreen shortcuts by:
- Giving them a spot in the app launcher
- Enabling web pages to open a Web APK when a user taps on a URL which belongs
  to a Web APK

This CL introduces a new APK target - "webapk". The APK's Android manifest can
be customized to launch different websites as a homescreen shortcut

BUG=609122
==========

[commit-bot: I haz the power, 2016-05-10 00:21:24]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-05-10 00:23:44]

Description was changed from

==========
Initial CL for Web APKs

Web APKs is a proposal to improve homescreen shortcuts by:
- Giving them a spot in the app launcher
- Enabling web pages to open a Web APK when a user taps on a URL which belongs
  to a Web APK

This CL introduces a new APK target - "webapk". The APK's Android manifest can
be customized to launch different websites as a homescreen shortcut

BUG=609122
==========

to

==========
Initial CL for Web APKs

Web APKs is a proposal to improve homescreen shortcuts by:
- Giving them a spot in the app launcher
- Enabling web pages to open a Web APK when a user taps on a URL which belongs
  to a Web APK

This CL introduces a new APK target - "webapk". The APK's Android manifest can
be customized to launch different websites as a homescreen shortcut

BUG=609122

Committed: https://crrev.com/2dd67964a3f0c7fb7cdf91bd5291e85625978d92
Cr-Commit-Position: refs/heads/master@{#392486}
==========

[commit-bot: I haz the power, 2016-05-10 00:23:45]

Patchset 4 (id:??) landed as
https://crrev.com/2dd67964a3f0c7fb7cdf91bd5291e85625978d92
Cr-Commit-Position: refs/heads/master@{#392486}