blimp/engine/BUILD.gn - Issue 1960813002: Fix DCHECK failure and add unittest for BlimpSystemURLContextGetter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/engine/BUILD.gn

Issue 1960813002: Fix DCHECK failure and add unittest for BlimpSystemURLContextGetter. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | blimp/engine/app/blimp_system_url_request_context_getter.cc » ('j') | blimp/engine/app/blimp_system_url_request_context_getter_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: blimp/engine/BUILD.gn

diff --git a/blimp/engine/BUILD.gn b/blimp/engine/BUILD.gn

index 3c9d0d794ddaeaf23b4708c7af79fb42fbfde93b..f0f368f30ce8b69ff8a760a78050f701798f0721 100644

--- a/blimp/engine/BUILD.gn

+++ b/blimp/engine/BUILD.gn

@@ -294,6 +294,7 @@ source_set("app_unit_tests") {

sources = [

"app/blimp_engine_config_unittest.cc",

+ "app/blimp_system_url_request_context_getter_unittest.cc",

"app/settings_manager_unittest.cc",

"app/ui/blimp_screen_unittest.cc",

]

@@ -301,12 +302,14 @@ source_set("app_unit_tests") {

deps = [

":app",

":app_config",

+ ":app_net",

":app_settings",

":app_switches",

"//base",

"//base/test:run_all_unittests",

"//base/test:test_support",

"//blimp/engine:app_ui",

+ "//content/test:test_support",

"//testing/gmock",

"//testing/gtest",

"//ui/display",