Fix DCHECK failure and add unittest for BlimpSystemURLContextGetter.

Fix DCHECK failure and add unittest for BlimpSystemURLContextGetter.

The URLRequestContextBuilder::Build calll in this function requires at least a dummy ProxyService to be set on linux builds. The nullptr ProxyService field in the context builder triggers a DCHECK on linux and android builds.

Also adding a minimal test to confirm fix and avoid regressions.

BUG=609998
Committed: https://crrev.com/20f84f3e73b8f4330659fa53ed11b9b5bc642d80
Cr-Commit-Position: refs/heads/master@{#392384}

[Jess, 2016-05-06 22:24:38]

Description was changed from

==========
Fix DCHECK failure and add unittest for BlimpSystemURLContextGetter.

URLRequestContextBuilder::Build requires at least a dummy ProxyService to be
set on linux builds. The nullptr ProxyService field in the context
builder triggers a DCHECK on linux and android builds.

Also adding a test to confirm fix and avoid regressions.


BUG=609998
==========

to

==========
Fix DCHECK failure and add unittest for BlimpSystemURLContextGetter.

The URLRequestContextBuilder::Build calll in this function requires at least a
dummy ProxyService to be
set on linux builds. The nullptr ProxyService field in the context
builder triggers a DCHECK on linux and android builds.

Also adding a test to confirm fix and avoid regressions.


BUG=609998
==========

[Jess, 2016-05-06 22:25:28]

Description was changed from

==========
Fix DCHECK failure and add unittest for BlimpSystemURLContextGetter.

The URLRequestContextBuilder::Build calll in this function requires at least a
dummy ProxyService to be
set on linux builds. The nullptr ProxyService field in the context
builder triggers a DCHECK on linux and android builds.

Also adding a test to confirm fix and avoid regressions.


BUG=609998
==========

to

==========
Fix DCHECK failure and add unittest for BlimpSystemURLContextGetter.

The URLRequestContextBuilder::Build calll in this function requires at least a
dummy ProxyService to be set on linux builds. The nullptr ProxyService field in
the context builder triggers a DCHECK on linux and android builds.

Also adding a minimal test to confirm fix and avoid regressions.


BUG=609998
==========

[Jess, 2016-05-06 22:25:49]

jessicag@chromium.org changed reviewers:
+ haibinlu@chromium.org, kmarshall@chromium.org

[Jess, 2016-05-06 22:25:50]

kmarshall@chromium.org: Please review changes in 

haibinlu@chromium.org: Please review changes in

[haibinlu, 2016-05-07 01:53:34]

https://codereview.chromium.org/1960813002/diff/1/blimp/engine/app/blimp_syst...
File blimp/engine/app/blimp_system_url_request_context_getter_unittest.cc
(right):

https://codereview.chromium.org/1960813002/diff/1/blimp/engine/app/blimp_syst...
blimp/engine/app/blimp_system_url_request_context_getter_unittest.cc:28:
content::TestBrowserThread ui_thread_;
 content::TestBrowserThread is deprecated?

[Jess, 2016-05-09 17:31:42]

PTAL

https://codereview.chromium.org/1960813002/diff/1/blimp/engine/app/blimp_syst...
File blimp/engine/app/blimp_system_url_request_context_getter_unittest.cc
(right):

https://codereview.chromium.org/1960813002/diff/1/blimp/engine/app/blimp_syst...
blimp/engine/app/blimp_system_url_request_context_getter_unittest.cc:28:
content::TestBrowserThread ui_thread_;
On 2016/05/07 01:53:34, haibinlu wrote:
>  content::TestBrowserThread is deprecated?

Thanks for catching that. TestBrowserThreadBundle is much cleaner. Done.

[haibinlu, 2016-05-09 17:36:48]

lgtm

[Jess, 2016-05-09 18:30:23]

The CQ bit was checked by jessicag@chromium.org

[commit-bot: I haz the power, 2016-05-09 18:31:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1960813002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1960813002/20001

[commit-bot: I haz the power, 2016-05-09 18:31:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-09 18:31:15]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[Kevin M, 2016-05-09 18:48:12]

lgtm

[Jess, 2016-05-09 18:48:37]

The CQ bit was checked by jessicag@chromium.org

[commit-bot: I haz the power, 2016-05-09 18:49:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1960813002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1960813002/20001

[commit-bot: I haz the power, 2016-05-09 18:54:36]

Description was changed from

==========
Fix DCHECK failure and add unittest for BlimpSystemURLContextGetter.

The URLRequestContextBuilder::Build calll in this function requires at least a
dummy ProxyService to be set on linux builds. The nullptr ProxyService field in
the context builder triggers a DCHECK on linux and android builds.

Also adding a minimal test to confirm fix and avoid regressions.


BUG=609998
==========

to

==========
Fix DCHECK failure and add unittest for BlimpSystemURLContextGetter.

The URLRequestContextBuilder::Build calll in this function requires at least a
dummy ProxyService to be set on linux builds. The nullptr ProxyService field in
the context builder triggers a DCHECK on linux and android builds.

Also adding a minimal test to confirm fix and avoid regressions.


BUG=609998
==========

[commit-bot: I haz the power, 2016-05-09 18:54:38]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-09 18:55:49]

Description was changed from

==========
Fix DCHECK failure and add unittest for BlimpSystemURLContextGetter.

The URLRequestContextBuilder::Build calll in this function requires at least a
dummy ProxyService to be set on linux builds. The nullptr ProxyService field in
the context builder triggers a DCHECK on linux and android builds.

Also adding a minimal test to confirm fix and avoid regressions.


BUG=609998
==========

to

==========
Fix DCHECK failure and add unittest for BlimpSystemURLContextGetter.

The URLRequestContextBuilder::Build calll in this function requires at least a
dummy ProxyService to be set on linux builds. The nullptr ProxyService field in
the context builder triggers a DCHECK on linux and android builds.

Also adding a minimal test to confirm fix and avoid regressions.

BUG=609998

Committed: https://crrev.com/20f84f3e73b8f4330659fa53ed11b9b5bc642d80
Cr-Commit-Position: refs/heads/master@{#392384}
==========

[commit-bot: I haz the power, 2016-05-09 18:55:50]

Patchset 2 (id:??) landed as
https://crrev.com/20f84f3e73b8f4330659fa53ed11b9b5bc642d80
Cr-Commit-Position: refs/heads/master@{#392384}