Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Issue 1960803002: Split the media context from the compositor worker context. (Closed)

Created:
4 years, 7 months ago by danakj
Modified:
4 years, 7 months ago
Reviewers:
Steven Holte, piman
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, asvitkine+watch_chromium.org, kalyank, mkwst+moarreviews-renderer_chromium.org, piman+watch_chromium.org, danakj+watch_chromium.org, Daniele Castagna, enne (OOO), Ken Russell (switch to Gerrit), piman, no sievers
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Split the media context from the compositor worker context. Give the media system its own ContextProviderCommandBuffer, so that we can move ownership of the compositor raster worker contex to the compositor thread along with the output surface. R=piman BUG=608946 Committed: https://crrev.com/0b4b94e39d65563ab62d634f02e2fb7a207b587f Cr-Commit-Position: refs/heads/master@{#392750}

Patch Set 1 #

Total comments: 2

Patch Set 2 : workerthread: media #

Patch Set 3 : workerthread: rebase #

Patch Set 4 : workerthread: streams #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -27 lines) Patch
M content/common/gpu/client/command_buffer_metrics.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/gpu/client/command_buffer_metrics.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M content/common/gpu_process_launch_causes.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_thread_impl.h View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 2 3 2 chunks +30 lines, -24 lines 0 comments Download
M content/renderer/render_widget.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 33 (14 generated)
danakj
4 years, 7 months ago (2016-05-06 22:10:58 UTC) #2
danakj
+holte@chromium.org for histograms
4 years, 7 months ago (2016-05-06 22:11:29 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1960803002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1960803002/1
4 years, 7 months ago (2016-05-06 22:11:35 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/156728)
4 years, 7 months ago (2016-05-06 23:08:58 UTC) #8
piman
https://codereview.chromium.org/1960803002/diff/1/content/renderer/render_thread_impl.cc File content/renderer/render_thread_impl.cc (right): https://codereview.chromium.org/1960803002/diff/1/content/renderer/render_thread_impl.cc#newcode1410 content/renderer/render_thread_impl.cc:1410: if (!shared_worker_context_provider_->BindToCurrentThread()) Did you mean shared_context_provider here?
4 years, 7 months ago (2016-05-06 23:38:57 UTC) #9
danakj
PTAL. It's media_context_provider now. https://codereview.chromium.org/1960803002/diff/1/content/renderer/render_thread_impl.cc File content/renderer/render_thread_impl.cc (right): https://codereview.chromium.org/1960803002/diff/1/content/renderer/render_thread_impl.cc#newcode1410 content/renderer/render_thread_impl.cc:1410: if (!shared_worker_context_provider_->BindToCurrentThread()) On 2016/05/06 23:38:57, ...
4 years, 7 months ago (2016-05-09 17:25:39 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1960803002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1960803002/20001
4 years, 7 months ago (2016-05-09 17:26:20 UTC) #12
piman
lgtm
4 years, 7 months ago (2016-05-09 17:27:47 UTC) #13
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-09 18:24:10 UTC) #15
Steven Holte
histograms lgtm
4 years, 7 months ago (2016-05-09 23:30:15 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1960803002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1960803002/20001
4 years, 7 months ago (2016-05-10 20:20:17 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-generic_chromium_compile_only_ng/builds/135082)
4 years, 7 months ago (2016-05-10 20:33:09 UTC) #20
danakj
Streams were added in the meantime. I made the media context get "default" stream like ...
4 years, 7 months ago (2016-05-10 21:05:00 UTC) #21
danakj
On 2016/05/10 21:05:00, danakj wrote: > Streams were added in the meantime. I made the ...
4 years, 7 months ago (2016-05-10 21:06:14 UTC) #22
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1960803002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1960803002/60001
4 years, 7 months ago (2016-05-10 21:06:55 UTC) #24
piman
LGTM, correct.
4 years, 7 months ago (2016-05-10 21:07:27 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1960803002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1960803002/60001
4 years, 7 months ago (2016-05-10 21:46:59 UTC) #29
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 7 months ago (2016-05-10 22:33:20 UTC) #31
commit-bot: I haz the power
4 years, 7 months ago (2016-05-10 22:36:10 UTC) #33
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/0b4b94e39d65563ab62d634f02e2fb7a207b587f
Cr-Commit-Position: refs/heads/master@{#392750}

Powered by Google App Engine
This is Rietveld 408576698