Issue 1960783002: Don't suggest types, getters, etc in 'for (Type ^)'.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1960783002: Don't suggest types, getters, etc in 'for (Type ^)'. (Closed)

Created:
4 years, 7 months ago by scheglov

Modified:
4 years, 7 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Don't suggest types, getters, etc in 'for (Type ^)'. Variable names should be suggested there. It does not work for the moment, I'll need to make changes into VariableNameContributor. But NOT suggesting all the garbage - for me thi is 90% of the full solution ;-) R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/522eaa9a803c0d8d54c4fc8e1a31cd4f488e0024

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+46 lines, -24 lines)			Patch
M	pkg/analysis_server/lib/src/services/completion/dart/optype.dart	View	3 chunks	+17 lines, -11 lines	0 comments	Download
M	pkg/analysis_server/test/services/completion/dart/imported_reference_contributor_test.dart	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/test/services/completion/dart/optype_test.dart	View	3 chunks	+23 lines, -13 lines	0 comments	Download

Total messages: 5 (1 generated)

scheglov

4 years, 7 months ago (2016-05-09 19:30:21 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
522eaa9a803c0d8d54c4fc8e1a31cd4f488e0024 (presubmit successful).