Issue 196073002: Move ScopedFILE to base namespace and scoped_file.h

Issue 196073002: Move ScopedFILE to base namespace and scoped_file.h (Closed)

Created:
6 years, 9 months ago by brettw

Modified:
6 years, 9 months ago

Reviewers:
viettrungluu

CC:
chromium-reviews, cbentzel+watch_chromium.org, hclam+watch_chromium.org, pwestin+watch_google.com, mikhal+watch_chromium.org, fischman+watch_chromium.org, jasonroberts+watch_google.com, jam, mcasas+watch_chromium.org, gavinp+memory_chromium.org, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, hguihot+watch_chromium.org, darin-cc_chromium.org, jln+watch_chromium.org, erikwright+watch_chromium.org, wjia+watch_chromium.org, agl, hubbe+watch_chromium.org, miu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Move ScopedFILE to base namespace and scoped_file.h R=viettrungluu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257518

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1

Patch Set 4 : #

Patch Set 5 : review comment #

Patch Set 6 : try fix #

Patch Set 7 : #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+64 lines, -40 lines)			Patch
M	base/files/scoped_file.h	View	1 2 3 4	3 chunks	+14 lines, -0 lines	0 comments	Download
M	base/memory/shared_memory.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	base/memory/shared_memory_posix.cc	View	1 2	2 chunks	+1 line, -2 lines	0 comments	Download
M	chrome/browser/safe_browsing/prefix_set.cc	View	1	3 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/safe_browsing/prefix_set_unittest.cc	View		8 chunks	+8 lines, -7 lines	0 comments	Download
M	chrome/browser/safe_browsing/safe_browsing_store_file.h	View	1 2 3	2 chunks	+4 lines, -3 lines	0 comments	Download
M	chrome/browser/safe_browsing/safe_browsing_store_file.cc	View	1 2 3	4 chunks	+6 lines, -4 lines	0 comments	Download
M	chrome/browser/safe_browsing/safe_browsing_store_file_unittest.cc	View	1 2 3 4 5	4 chunks	+5 lines, -3 lines	0 comments	Download
M	components/visitedlink/browser/visitedlink_master.cc	View		3 chunks	+2 lines, -2 lines	0 comments	Download
M	content/browser/renderer_host/media/video_capture_host_unittest.cc	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	content/common/sandbox_mac_fontloading_unittest.mm	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	media/cast/test/sender.cc	View	1	4 chunks	+6 lines, -7 lines	0 comments	Download
M	net/proxy/proxy_config_service_linux.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	sandbox/linux/services/credentials.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sql/connection_unittest.cc	View		4 chunks	+4 lines, -3 lines	0 comments	Download
M	sql/test/test_helpers.cc	View		3 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

lgtm w/nit https://codereview.chromium.org/196073002/diff/40001/base/files/scoped_file.h File base/files/scoped_file.h (right): https://codereview.chromium.org/196073002/diff/40001/base/files/scoped_file.h#newcode30 base/files/scoped_file.h:30: struct ScopedFILEClose { Since scoped_ptr.h refers to ...

6 years, 9 months ago (2014-03-14 21:41:56 UTC) #3

Message was sent while issue was closed.

Committed patchset #7 manually as r257518.

Expand Messages | Collapse Messages