Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(758)

Issue 1960703004: Revert of mojo: make libmojo_public_test_support a static library. (Closed)

Created:
4 years, 7 months ago by krasin1
Modified:
4 years, 7 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of mojo: make libmojo_public_test_support a static library. (patchset #8 id:140001 of https://codereview.chromium.org/1953503004/ ) Reason for revert: Broke official builds. BUG=610020 Original issue's description: > mojo: make libmojo_public_test_support a static library. > > The plan is to eventually get rid of it completely, but > for now, we want to remove ODR violations related to > MOJO_TEST_SUPPORT_EXPORT macro in non-components build. > > BUG=609564, 515347 > > Committed: https://crrev.com/7b2368d72cd3c3fe3236ce679ed5adda380760f2 > Cr-Commit-Position: refs/heads/master@{#392180} TBR=rockot@chromium.org,krasin@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=609564, 515347 Committed: https://crrev.com/0cc1fb3aedf871cf08d3a218105d14e8ff41198b Cr-Commit-Position: refs/heads/master@{#392216}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -13 lines) Patch
M mojo/common/BUILD.gn View 2 chunks +12 lines, -0 lines 0 comments Download
A mojo/mojo.isolate View 1 chunk +31 lines, -0 lines 0 comments Download
M mojo/mojo_common_unittests.isolate View 1 chunk +1 line, -1 line 0 comments Download
M mojo/mojo_js_integration_tests.isolate View 1 chunk +1 line, -1 line 0 comments Download
M mojo/mojo_js_unittests.isolate View 1 chunk +1 line, -1 line 0 comments Download
M mojo/mojo_public.gyp View 2 chunks +17 lines, -1 line 0 comments Download
M mojo/mojo_public_bindings_unittests.isolate View 1 chunk +1 line, -1 line 0 comments Download
M mojo/mojo_public_system_unittests.isolate View 1 chunk +1 line, -1 line 0 comments Download
M mojo/mojo_system_unittests.isolate View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/c/test_support/BUILD.gn View 1 chunk +11 lines, -2 lines 0 comments Download
M mojo/public/c/test_support/test_support.h View 3 chunks +5 lines, -2 lines 0 comments Download
A mojo/public/c/test_support/test_support_export.h View 1 chunk +26 lines, -0 lines 0 comments Download
M mojo/public/tests/test_support_private.h View 1 chunk +1 line, -1 line 0 comments Download
M services/shell/mojo_shell_unittests.isolate View 1 chunk +1 line, -1 line 0 comments Download
M tools/cfi/blacklist.txt View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
krasin1
Created Revert of mojo: make libmojo_public_test_support a static library.
4 years, 7 months ago (2016-05-07 00:27:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1960703004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1960703004/1
4 years, 7 months ago (2016-05-07 00:28:11 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-07 00:28:54 UTC) #4
commit-bot: I haz the power
4 years, 7 months ago (2016-05-07 00:30:22 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0cc1fb3aedf871cf08d3a218105d14e8ff41198b
Cr-Commit-Position: refs/heads/master@{#392216}

Powered by Google App Engine
This is Rietveld 408576698