Source/bindings/scripts/idl_compiler.py - Issue 19607011: Generate binding code for VoidCallback.idl with code generator in python

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/idl_compiler.py

Issue 19607011: Generate binding code for VoidCallback.idl with code generator in python (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@master

Patch Set: smaller Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/scripts/code_generator_v8.py ('K') | « Source/bindings/scripts/code_generator_v8.py ('k') | Source/bindings/templates/callback.h » ('j') | Source/bindings/templates/callback.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/scripts/idl_compiler.py

diff --git a/Source/bindings/scripts/idl_compiler.py b/Source/bindings/scripts/idl_compiler.py

index e47843d2f55d9bf2c3e9770eee52d1829de01ec2..86a55ec49083fc5842bd0a55f7c04e325efd63df 100755

--- a/Source/bindings/scripts/idl_compiler.py

+++ b/Source/bindings/scripts/idl_compiler.py

@@ -112,12 +112,8 @@ def main():

if options.dump_json_and_pickle:

write_json_and_pickle(definitions, interface_name, output_directory)

return

- # FIXME: turn on code generator

- # Currently definitions must be None (so dummy .h and .cpp files are

- # generated), or --dump-json-and-pickle selected, as actual code generator

- # not present yet.

- # code_generator_v8.write_interface(definitions, interface_name, options.output_directory)

- raise RuntimeError('Stub: code generator not implemented yet')

+ code_generator = code_generator_v8.CodeGeneratorV8(definitions, interface_name, options.output_directory, options.idl_directories, verbose)

+ code_generator.generate_header_and_cpp()

if __name__ == '__main__':