Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Unified Diff: Source/bindings/scripts/idl_compiler.py

Issue 19607011: Generate binding code for VoidCallback.idl with code generator in python (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@master
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/scripts/idl_compiler.py
diff --git a/Source/bindings/scripts/idl_compiler.py b/Source/bindings/scripts/idl_compiler.py
index 7400b06d21cfaeda5914cdd2c7dfef82790d77e9..6356d9267b43866394a1020c5865bfc4c655efb5 100755
--- a/Source/bindings/scripts/idl_compiler.py
+++ b/Source/bindings/scripts/idl_compiler.py
@@ -110,12 +110,8 @@ def main():
if options.dump_json_and_pickle:
write_json_and_pickle(definitions, interface_name, options.output_directory)
return
- # FIXME: turn on code generator
- # Currently definitions must be None (so dummy .h and .cpp files are
- # generated), or --dump-json-and-pickle selected, as actual code generator
- # not present yet.
- # code_generator_v8.write_interface(definitions, interface_name, options.output_directory)
- raise RuntimeError('Stub: code generator not implemented yet')
+ code_generator = code_generator_v8.code_generator_v8(definitions, interface_name, options.output_directory, idl_directories=options.idl_directories, verbose=options.verbose)
Nils Barth (inactive) 2013/07/24 11:41:20 This can be made shorter in a few ways: * verbose
+ code_generator.write_interface()
if __name__ == '__main__':

Powered by Google App Engine
This is Rietveld 408576698