Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1960663003: DevTools: introduce the Clear storage pane in the resources panel. (Closed)

Created:
4 years, 7 months ago by pfeldman
Modified:
4 years, 7 months ago
Reviewers:
alph
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: introduce the Clear storage pane in the resources panel. BUG=609950 NOTRY=true Committed: https://crrev.com/46104c6eef94be824a4b1ba58cf0b50b92c2979b Cr-Commit-Position: refs/heads/master@{#392269}

Patch Set 1 #

Patch Set 2 : missing file added #

Patch Set 3 : enum is used #

Patch Set 4 : tests fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+390 lines, -34 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/cache-storage/cache-storage-test.js View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/devtools.gypi View 2 chunks +2 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/devtools/front_end/resources/ClearStorageView.js View 1 2 1 chunk +161 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/DOMStorageModel.js View 3 chunks +19 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/DatabaseModel.js View 2 chunks +13 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/IndexedDBModel.js View 1 chunk +12 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js View 1 2 3 11 chunks +101 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js View 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/Source/devtools/front_end/resources/clearStorageView.css View 1 chunk +25 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/module.json View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/ApplicationCacheModel.js View 6 chunks +20 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerCacheModel.js View 1 chunk +12 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/ReportView.js View 3 chunks +19 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/reportView.css View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 32 (17 generated)
pfeldman
4 years, 7 months ago (2016-05-06 23:03:15 UTC) #2
alph
lgtm
4 years, 7 months ago (2016-05-06 23:46:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1960663003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1960663003/1
4 years, 7 months ago (2016-05-07 00:04:19 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_rel/builds/107557)
4 years, 7 months ago (2016-05-07 00:15:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1960663003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1960663003/40001
4 years, 7 months ago (2016-05-07 00:55:16 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/209943)
4 years, 7 months ago (2016-05-07 01:43:22 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1960663003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1960663003/60001
4 years, 7 months ago (2016-05-07 03:42:49 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/225110)
4 years, 7 months ago (2016-05-07 04:37:41 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1960663003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1960663003/60001
4 years, 7 months ago (2016-05-07 14:17:46 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/223848)
4 years, 7 months ago (2016-05-07 15:47:40 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1960663003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1960663003/60001
4 years, 7 months ago (2016-05-07 22:39:40 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/223890)
4 years, 7 months ago (2016-05-07 23:40:23 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1960663003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1960663003/60001
4 years, 7 months ago (2016-05-08 00:03:51 UTC) #28
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 7 months ago (2016-05-08 00:08:21 UTC) #30
commit-bot: I haz the power
4 years, 7 months ago (2016-05-08 00:09:55 UTC) #32
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/46104c6eef94be824a4b1ba58cf0b50b92c2979b
Cr-Commit-Position: refs/heads/master@{#392269}

Powered by Google App Engine
This is Rietveld 408576698