Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 1960553003: Update NTP to new material design spec. (Closed)

Created:
4 years, 7 months ago by May
Modified:
4 years, 7 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, mcwilliams+watch_chromium.org, dgn+watch_chromium.org, Ted C
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update NTP to new material design spec. Also add a feature flag so we can disable if necessary. Screenshots here of NTP with snippets off and snippets on: http://imgur.com/a/Wd04S BUG=609112 Committed: https://crrev.com/61ca55404d889f1c66821603075ecd096958e5b7 Cr-Commit-Position: refs/heads/master@{#392250}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -12 lines) Patch
M chrome/android/java/res/layout/new_tab_page_recycler_view.xml View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/res/layout/new_tab_page_view.xml View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/java/res/values/colors.xml View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java View 3 chunks +4 lines, -5 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageScrollView.java View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageToolbar.java View 1 chunk +2 lines, -0 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/ntp/NtpColorUtils.java View 1 1 chunk +27 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/interests/InterestsPage.java View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninView.java View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/android/java_sources.gni View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/android/chrome_feature_list.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/android/chrome_feature_list.cc View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
May
4 years, 7 months ago (2016-05-06 15:48:21 UTC) #3
Bernhard Bauer
+Ted FYI What does this look like when the bottom toolbar overlaps the Most Visited ...
4 years, 7 months ago (2016-05-06 15:58:41 UTC) #4
May
On 2016/05/06 15:58:41, Bernhard Bauer wrote: > +Ted FYI > > What does this look ...
4 years, 7 months ago (2016-05-06 16:01:13 UTC) #5
May
On 2016/05/06 16:01:13, May wrote: > On 2016/05/06 15:58:41, Bernhard Bauer wrote: > > +Ted ...
4 years, 7 months ago (2016-05-06 16:03:18 UTC) #6
May
https://codereview.chromium.org/1960553003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ntp/NtpColorUtils.java File chrome/android/java/src/org/chromium/chrome/browser/ntp/NtpColorUtils.java (right): https://codereview.chromium.org/1960553003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ntp/NtpColorUtils.java#newcode17 chrome/android/java/src/org/chromium/chrome/browser/ntp/NtpColorUtils.java:17: public class NtpColorUtils { On 2016/05/06 15:58:41, Bernhard Bauer ...
4 years, 7 months ago (2016-05-06 16:04:21 UTC) #7
Bernhard Bauer
On 2016/05/06 16:03:18, May wrote: > On 2016/05/06 16:01:13, May wrote: > > On 2016/05/06 ...
4 years, 7 months ago (2016-05-06 16:06:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1960553003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1960553003/20001
4 years, 7 months ago (2016-05-07 07:57:12 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-07 08:01:42 UTC) #12
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/61ca55404d889f1c66821603075ecd096958e5b7 Cr-Commit-Position: refs/heads/master@{#392250}
4 years, 7 months ago (2016-05-07 08:03:32 UTC) #14
May
4 years, 7 months ago (2016-05-09 16:41:30 UTC) #15
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1962063002/ by maybelle@chromium.org.

The reason for reverting is: Regression cause in incognito:
https://bugs.chromium.org/p/chromium/issues/detail?id=610192.

Powered by Google App Engine
This is Rietveld 408576698