Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9000)

Unified Diff: cc/output/direct_renderer.cc

Issue 1960543002: Optimize render passes with single quads (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Now with correct filter inputs Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/output/direct_renderer.cc
diff --git a/cc/output/direct_renderer.cc b/cc/output/direct_renderer.cc
index 7554a97e3543219800d295c10faab1df75e5a728..59bd670c0416aec12f357571317847b9fdbfef0f 100644
--- a/cc/output/direct_renderer.cc
+++ b/cc/output/direct_renderer.cc
@@ -141,14 +141,26 @@ DirectRenderer::DirectRenderer(RendererClient* client,
DirectRenderer::~DirectRenderer() {}
+const TileDrawQuad* DirectRenderer::CanPassBeDrawnDirectly(
+ const RenderPass* pass) {
+ return nullptr;
+}
+
void DirectRenderer::DecideRenderPassAllocationsForFrame(
const RenderPassList& render_passes_in_draw_order) {
+ render_pass_bypass_quads_.clear();
+
std::unordered_map<RenderPassId, gfx::Size, RenderPassIdHash>
render_passes_in_frame;
- for (size_t i = 0; i < render_passes_in_draw_order.size(); ++i)
+ for (size_t i = 0; i < render_passes_in_draw_order.size(); ++i) {
+ RenderPass* pass = render_passes_in_draw_order[i].get();
+ if (const TileDrawQuad* tile_quad = CanPassBeDrawnDirectly(pass)) {
+ render_pass_bypass_quads_[pass->id] = *tile_quad;
+ continue;
+ }
render_passes_in_frame.insert(std::pair<RenderPassId, gfx::Size>(
- render_passes_in_draw_order[i]->id,
- RenderPassTextureSize(render_passes_in_draw_order[i].get())));
+ pass->id, RenderPassTextureSize(pass)));
+ }
std::vector<RenderPassId> passes_to_delete;
for (auto pass_iter = render_pass_textures_.begin();
@@ -405,6 +417,11 @@ void DirectRenderer::FlushPolygons(
void DirectRenderer::DrawRenderPassAndExecuteCopyRequests(
DrawingFrame* frame,
RenderPass* render_pass) {
+ if (render_pass_bypass_quads_.find(render_pass->id) !=
+ render_pass_bypass_quads_.end()) {
+ return;
+ }
+
DrawRenderPass(frame, render_pass);
bool first_request = true;
« no previous file with comments | « cc/output/direct_renderer.h ('k') | cc/output/gl_renderer.h » ('j') | cc/output/gl_renderer.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698