Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(934)

Side by Side Diff: cc/output/direct_renderer.cc

Issue 1960543002: Optimize render passes with single quads (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix context menus Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/output/direct_renderer.h ('k') | cc/output/gl_renderer.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/output/direct_renderer.h" 5 #include "cc/output/direct_renderer.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <unordered_map> 9 #include <unordered_map>
10 #include <utility> 10 #include <utility>
(...skipping 123 matching lines...) Expand 10 before | Expand all | Expand 10 after
134 ResourceProvider* resource_provider) 134 ResourceProvider* resource_provider)
135 : Renderer(client, settings), 135 : Renderer(client, settings),
136 output_surface_(output_surface), 136 output_surface_(output_surface),
137 resource_provider_(resource_provider), 137 resource_provider_(resource_provider),
138 overlay_processor_(new OverlayProcessor(output_surface)) { 138 overlay_processor_(new OverlayProcessor(output_surface)) {
139 overlay_processor_->Initialize(); 139 overlay_processor_->Initialize();
140 } 140 }
141 141
142 DirectRenderer::~DirectRenderer() {} 142 DirectRenderer::~DirectRenderer() {}
143 143
144 const TileDrawQuad* DirectRenderer::CanPassBeDrawnDirectly(
145 const RenderPass* pass) {
146 return nullptr;
147 }
148
144 void DirectRenderer::DecideRenderPassAllocationsForFrame( 149 void DirectRenderer::DecideRenderPassAllocationsForFrame(
145 const RenderPassList& render_passes_in_draw_order) { 150 const RenderPassList& render_passes_in_draw_order) {
151 render_pass_bypass_quads_.clear();
152
146 std::unordered_map<RenderPassId, gfx::Size, RenderPassIdHash> 153 std::unordered_map<RenderPassId, gfx::Size, RenderPassIdHash>
147 render_passes_in_frame; 154 render_passes_in_frame;
148 for (size_t i = 0; i < render_passes_in_draw_order.size(); ++i) 155 RenderPass* root_render_pass = render_passes_in_draw_order.back().get();
156 for (size_t i = 0; i < render_passes_in_draw_order.size(); ++i) {
157 RenderPass* pass = render_passes_in_draw_order[i].get();
158 if (pass != root_render_pass) {
enne (OOO) 2016/06/13 18:41:17 Maybe we shouldn't drop the root render pass? Thi
159 if (const TileDrawQuad* tile_quad = CanPassBeDrawnDirectly(pass)) {
160 render_pass_bypass_quads_[pass->id] = *tile_quad;
161 continue;
162 }
163 }
149 render_passes_in_frame.insert(std::pair<RenderPassId, gfx::Size>( 164 render_passes_in_frame.insert(std::pair<RenderPassId, gfx::Size>(
150 render_passes_in_draw_order[i]->id, 165 pass->id, RenderPassTextureSize(pass)));
151 RenderPassTextureSize(render_passes_in_draw_order[i].get()))); 166 }
152 167
153 std::vector<RenderPassId> passes_to_delete; 168 std::vector<RenderPassId> passes_to_delete;
154 for (auto pass_iter = render_pass_textures_.begin(); 169 for (auto pass_iter = render_pass_textures_.begin();
155 pass_iter != render_pass_textures_.end(); ++pass_iter) { 170 pass_iter != render_pass_textures_.end(); ++pass_iter) {
156 auto it = render_passes_in_frame.find(pass_iter->first); 171 auto it = render_passes_in_frame.find(pass_iter->first);
157 if (it == render_passes_in_frame.end()) { 172 if (it == render_passes_in_frame.end()) {
158 passes_to_delete.push_back(pass_iter->first); 173 passes_to_delete.push_back(pass_iter->first);
159 continue; 174 continue;
160 } 175 }
161 176
(...skipping 236 matching lines...) Expand 10 before | Expand all | Expand 10 after
398 BspTree bsp_tree(poly_list); 413 BspTree bsp_tree(poly_list);
399 BspWalkActionDrawPolygon action_handler(this, frame, render_pass_scissor, 414 BspWalkActionDrawPolygon action_handler(this, frame, render_pass_scissor,
400 use_render_pass_scissor); 415 use_render_pass_scissor);
401 bsp_tree.TraverseWithActionHandler(&action_handler); 416 bsp_tree.TraverseWithActionHandler(&action_handler);
402 DCHECK(poly_list->empty()); 417 DCHECK(poly_list->empty());
403 } 418 }
404 419
405 void DirectRenderer::DrawRenderPassAndExecuteCopyRequests( 420 void DirectRenderer::DrawRenderPassAndExecuteCopyRequests(
406 DrawingFrame* frame, 421 DrawingFrame* frame,
407 RenderPass* render_pass) { 422 RenderPass* render_pass) {
423 if (render_pass_bypass_quads_.find(render_pass->id) !=
424 render_pass_bypass_quads_.end()) {
425 return;
426 }
427
408 DrawRenderPass(frame, render_pass); 428 DrawRenderPass(frame, render_pass);
409 429
410 bool first_request = true; 430 bool first_request = true;
411 for (auto& copy_request : render_pass->copy_requests) { 431 for (auto& copy_request : render_pass->copy_requests) {
412 // Doing a readback is destructive of our state on Mac, so make sure 432 // Doing a readback is destructive of our state on Mac, so make sure
413 // we restore the state between readbacks. http://crbug.com/99393. 433 // we restore the state between readbacks. http://crbug.com/99393.
414 if (!first_request) 434 if (!first_request)
415 UseRenderPass(frame, render_pass); 435 UseRenderPass(frame, render_pass);
416 CopyCurrentRenderPassToBitmap(frame, std::move(copy_request)); 436 CopyCurrentRenderPassToBitmap(frame, std::move(copy_request));
417 first_request = false; 437 first_request = false;
(...skipping 136 matching lines...) Expand 10 before | Expand all | Expand 10 after
554 auto iter = render_pass_textures_.find(id); 574 auto iter = render_pass_textures_.find(id);
555 return iter != render_pass_textures_.end() && iter->second->id(); 575 return iter != render_pass_textures_.end() && iter->second->id();
556 } 576 }
557 577
558 // static 578 // static
559 gfx::Size DirectRenderer::RenderPassTextureSize(const RenderPass* render_pass) { 579 gfx::Size DirectRenderer::RenderPassTextureSize(const RenderPass* render_pass) {
560 return render_pass->output_rect.size(); 580 return render_pass->output_rect.size();
561 } 581 }
562 582
563 } // namespace cc 583 } // namespace cc
OLDNEW
« no previous file with comments | « cc/output/direct_renderer.h ('k') | cc/output/gl_renderer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698