Issue 196053011: Revert of Revert of Show IME when DPAD_CENTER is pressed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 196053011: Revert of Revert of Show IME when DPAD_CENTER is pressed (Closed)

Created:
6 years, 9 months ago by pneubeck (no reviews)

Modified:
6 years, 9 months ago

Reviewers:
Primiano Tucci (use gerrit), sgurun-gerrit only, jdduke (slow), aurimas (slooooooooow), hush (inactive)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, android-webview-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

Revert of Revert of Show IME when DPAD_CENTER is pressed (https://codereview.chromium.org/206333002/) Reason for revert: Was reverted by mistake and broke the tree. Reverting the revert. Original issue's description: > Revert of Show IME when DPAD_CENTER is pressed (https://codereview.chromium.org/161933002/) > > Reason for revert: > Re-addressing this in crrev.com/206113005/ > > Original issue's description: > > Show IME when DPAD_CENTER is pressed > > > > BUG=343311 > > > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251447 > > TBR=jdduke@chromium.org,sgurun@chromium.org,aurimas@chromium.org,hush@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=343311 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258262 TBR=jdduke@chromium.org,sgurun@chromium.org,aurimas@chromium.org,hush@chromium.org,primiano@chromium.org NOTREECHECKS=true NOTRY=true BUG=343311 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258265

Created: 6 years, 9 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+79 lines, -0 lines)			Patch
	M	content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java	View		2 chunks	+16 lines, -0 lines	0 comments	Download
	A	content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreDpadTest.java	View		1 chunk	+63 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

pneubeck (no reviews)

Created Revert of Revert of Show IME when DPAD_CENTER is pressed

6 years, 9 months ago (2014-03-20 11:02:52 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pneubeck@chromium.org/196053011/1

6 years, 9 months ago (2014-03-20 11:02:58 UTC) #2

Message was sent while issue was closed.

Change committed as 258265