Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 196053008: Add varz to track QUIC packets and bytes sent by transmission type. (Closed)

Created:
6 years, 9 months ago by ramant (doing other things)
Modified:
6 years, 9 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, eroman, mmenke
Visibility:
Public.

Description

Add varz to track QUIC packets and bytes sent by transmission type. Not flag protected. Merge internal change: 63037893 + Updated QuicConnectionLogger to log TransmissionType. + Used connection_id instead of GUID in the comments. + Moved QUIC_SESSION_PACKET_SENT and QUIC_SESSION_PACKET_RETRANSMITTED to match the log messages description. R=rch@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -24 lines) Patch
M net/base/net_log_event_type_list.h View 3 chunks +8 lines, -5 lines 0 comments Download
M net/quic/quic_connection.h View 1 chunk +15 lines, -14 lines 0 comments Download
M net/quic/quic_connection.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M net/quic/quic_connection_logger.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_connection_logger.cc View 2 chunks +4 lines, -1 line 0 comments Download
M net/quic/quic_connection_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/quic_packet_generator.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_utils.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/quic_utils.cc View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ramant (doing other things)
6 years, 9 months ago (2014-03-13 03:20:43 UTC) #1
Ryan Hamilton
6 years, 9 months ago (2014-03-13 15:27:26 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698