Support module root

Support module root

Fixes #553

R=sigmund@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/a0557e2f76fc85a6e71fe8391d1beda69905a548

[vsm, 2016-05-06 00:24:58]

Description was changed from

==========
Support module root

Fixes #553
==========

to

==========
Support module root

Fixes #553
==========

[vsm, 2016-05-06 00:24:58]

vsm@google.com changed reviewers:
+ jmesserly@google.com, sigmund@google.com

[Siggi Cherem (dart-lang), 2016-05-06 01:09:49]

lgtm!

https://codereview.chromium.org/1960523002/diff/20001/lib/src/compiler/comman...
File lib/src/compiler/command.dart (right):

https://codereview.chromium.org/1960523002/diff/20001/lib/src/compiler/comman...
lib/src/compiler/command.dart:30: argParser.addOption('build-root',
not for right now, but just thinking about how to make the names of these 2
flags consistent. Maybe rename this as `library-root`?

https://codereview.chromium.org/1960523002/diff/20001/lib/src/compiler/comman...
lib/src/compiler/command.dart:60: usageException('Output file $outPath must be
within the $moduleRoot '
nit: maybe spell out "module root" to make it clear where the value of
$moduleRoot comes from.

https://codereview.chromium.org/1960523002/diff/20001/lib/src/compiler/comman...
lib/src/compiler/command.dart:100: 'Imported file ${source.uri} is not within
the $moduleRoot '
here too

[vsm, 2016-05-06 01:17:49]

https://codereview.chromium.org/1960523002/diff/20001/lib/src/compiler/comman...
File lib/src/compiler/command.dart (right):

https://codereview.chromium.org/1960523002/diff/20001/lib/src/compiler/comman...
lib/src/compiler/command.dart:30: argParser.addOption('build-root',
On 2016/05/06 01:09:49, Siggi Cherem (dart-lang) wrote:
> not for right now, but just thinking about how to make the names of these 2
> flags consistent. Maybe rename this as `library-root`?

Acknowledged.

https://codereview.chromium.org/1960523002/diff/20001/lib/src/compiler/comman...
lib/src/compiler/command.dart:60: usageException('Output file $outPath must be
within the $moduleRoot '
On 2016/05/06 01:09:49, Siggi Cherem (dart-lang) wrote:
> nit: maybe spell out "module root" to make it clear where the value of
> $moduleRoot comes from.

Done.

https://codereview.chromium.org/1960523002/diff/20001/lib/src/compiler/comman...
lib/src/compiler/command.dart:100: 'Imported file ${source.uri} is not within
the $moduleRoot '
On 2016/05/06 01:09:49, Siggi Cherem (dart-lang) wrote:
> here too

Done.

[vsm, 2016-05-06 01:18:01]

Description was changed from

==========
Support module root

Fixes #553
==========

to

==========
Support module root

Fixes #553

R=sigmund@google.com

Committed:
https://github.com/dart-lang/dev_compiler/commit/a0557e2f76fc85a6e71fe8391d1b...
==========

[vsm, 2016-05-06 01:18:02]

Committed patchset #3 (id:40001) manually as
a0557e2f76fc85a6e71fe8391d1beda69905a548 (presubmit successful).

[Jennifer Messerly, 2016-05-06 17:15:18]

lgtm

https://codereview.chromium.org/1960523002/diff/40001/lib/src/compiler/comman...
File lib/src/compiler/command.dart (right):

https://codereview.chromium.org/1960523002/diff/40001/lib/src/compiler/comman...
lib/src/compiler/command.dart:30: argParser.addOption('build-root',
in retrospect, this looks like it should be "library-root" ?

(based on the documentation)