Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issue 1960513002: [Merge to M50] IPC: Fix attachment brokering race condition. (Closed)

Created:
4 years, 7 months ago by erikchen
Modified:
4 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

[Merge to M50] IPC: Fix attachment brokering race condition. This CL is a merge of the safest, and most importance pieces https://codereview.chromium.org/1917333002/ to M50. There is a race condition where an IPC::Channel can start processing messages before it is registered as a communication channel with the attachment broker. This CL reorders channel connection and registration. BUG=598088, 609262 R=avi@chromium.org, mseaborn@chromium.org, tsepez@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/75ca2da31f0449be76215e6c4cddd371d2631e50

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -16 lines) Patch
M components/nacl/loader/nacl_listener.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 3 chunks +18 lines, -9 lines 0 comments Download
M content/child/child_thread_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/child_process_host_impl.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M ipc/ipc_channel_proxy.h View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
erikchen
avi: Please review content/ tsepez: Please review ipc/ mseaborn: Please review components/nacl Note that M50 ...
4 years, 7 months ago (2016-05-06 00:07:07 UTC) #7
Mark Seaborn
On 2016/05/06 00:07:07, erikchen wrote: > mseaborn: Please review components/nacl LGTM
4 years, 7 months ago (2016-05-06 01:09:34 UTC) #8
Avi (use Gerrit)
lgtm stamp
4 years, 7 months ago (2016-05-06 02:33:16 UTC) #9
Tom Sepez
On 2016/05/06 02:33:16, Avi wrote: > lgtm > > stamp RS LGTM
4 years, 7 months ago (2016-05-06 17:40:47 UTC) #10
erikchen
4 years, 7 months ago (2016-05-06 17:46:08 UTC) #12
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
75ca2da31f0449be76215e6c4cddd371d2631e50 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698