[Merge to M50] IPC: Fix attachment brokering race condition.

[Merge to M50] IPC: Fix attachment brokering race condition.

This CL is a merge of the safest, and most importance pieces
https://codereview.chromium.org/1917333002/ to M50.

There is a race condition where an IPC::Channel can start processing messages
before it is registered as a communication channel with the attachment broker.
This CL reorders channel connection and registration.

BUG=598088, 609262
R=avi@chromium.org, mseaborn@chromium.org, tsepez@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/75ca2da31f0449be76215e6c4cddd371d2631e50

[erikchen, 2016-05-06 00:02:33]

Description was changed from

==========
[Merge to M50] Partial attachment brokering fix.

Not ready for review.

BUG=
==========

to

==========
[Merge to M50] IPC: Fix attachment brokering race condition.

This CL is a merge of the safest, and most importance pieces
https://codereview.chromium.org/1917333002/ to M50.

There is a race condition where an IPC::Channel can start processing messages
before it is registered as a communication channel with the attachment broker.
This CL reorders channel initialization and registration.

BUG=
==========

[erikchen, 2016-05-06 00:04:28]

Description was changed from

==========
[Merge to M50] IPC: Fix attachment brokering race condition.

This CL is a merge of the safest, and most importance pieces
https://codereview.chromium.org/1917333002/ to M50.

There is a race condition where an IPC::Channel can start processing messages
before it is registered as a communication channel with the attachment broker.
This CL reorders channel initialization and registration.

BUG=
==========

to

==========
[Merge to M50] IPC: Fix attachment brokering race condition.

This CL is a merge of the safest, and most importance pieces
https://codereview.chromium.org/1917333002/ to M50.

There is a race condition where an IPC::Channel can start processing messages
before it is registered as a communication channel with the attachment broker.
This CL reorders channel connection and registration.

BUG=
==========

[erikchen, 2016-05-06 00:04:39]

Description was changed from

==========
[Merge to M50] IPC: Fix attachment brokering race condition.

This CL is a merge of the safest, and most importance pieces
https://codereview.chromium.org/1917333002/ to M50.

There is a race condition where an IPC::Channel can start processing messages
before it is registered as a communication channel with the attachment broker.
This CL reorders channel connection and registration.

BUG=
==========

to

==========
[Merge to M50] IPC: Fix attachment brokering race condition.

This CL is a merge of the safest, and most importance pieces
https://codereview.chromium.org/1917333002/ to M50.

There is a race condition where an IPC::Channel can start processing messages
before it is registered as a communication channel with the attachment broker.
This CL reorders channel connection and registration.

BUG=598088
==========

[erikchen, 2016-05-06 00:05:01]

Description was changed from

==========
[Merge to M50] IPC: Fix attachment brokering race condition.

This CL is a merge of the safest, and most importance pieces
https://codereview.chromium.org/1917333002/ to M50.

There is a race condition where an IPC::Channel can start processing messages
before it is registered as a communication channel with the attachment broker.
This CL reorders channel connection and registration.

BUG=598088
==========

to

==========
[Merge to M50] IPC: Fix attachment brokering race condition.

This CL is a merge of the safest, and most importance pieces
https://codereview.chromium.org/1917333002/ to M50.

There is a race condition where an IPC::Channel can start processing messages
before it is registered as a communication channel with the attachment broker.
This CL reorders channel connection and registration.

BUG=598088, 609262
==========

[erikchen, 2016-05-06 00:05:24]

Description was changed from

==========
[Merge to M50] IPC: Fix attachment brokering race condition.

This CL is a merge of the safest, and most importance pieces
https://codereview.chromium.org/1917333002/ to M50.

There is a race condition where an IPC::Channel can start processing messages
before it is registered as a communication channel with the attachment broker.
This CL reorders channel connection and registration.

BUG=598088, 609262
==========

to

==========
[Merge to M50] IPC: Fix attachment brokering race condition.

This CL is a merge of the safest, and most importance pieces
https://codereview.chromium.org/1917333002/ to M50.

There is a race condition where an IPC::Channel can start processing messages
before it is registered as a communication channel with the attachment broker.
This CL reorders channel connection and registration.

BUG=598088, 609262
==========

[erikchen, 2016-05-06 00:07:07]

erikchen@chromium.org changed reviewers:
+ avi@chromium.org, mseaborn@chromium.org, tsepez@chromium.org

[erikchen, 2016-05-06 00:07:07]

avi: Please review content/
tsepez: Please review ipc/
mseaborn: Please review components/nacl

Note that M50 may be respun on Monday, so I may be aggressively pinging you or
finding other OWNERs.

[Mark Seaborn, 2016-05-06 01:09:34]

On 2016/05/06 00:07:07, erikchen wrote:
> mseaborn: Please review components/nacl

LGTM

[Avi (use Gerrit), 2016-05-06 02:33:16]

lgtm

stamp

[Tom Sepez, 2016-05-06 17:40:47]

On 2016/05/06 02:33:16, Avi wrote:
> lgtm
> 
> stamp

RS LGTM

[erikchen, 2016-05-06 17:46:06]

Description was changed from

==========
[Merge to M50] IPC: Fix attachment brokering race condition.

This CL is a merge of the safest, and most importance pieces
https://codereview.chromium.org/1917333002/ to M50.

There is a race condition where an IPC::Channel can start processing messages
before it is registered as a communication channel with the attachment broker.
This CL reorders channel connection and registration.

BUG=598088, 609262
==========

to

==========
[Merge to M50] IPC: Fix attachment brokering race condition.

This CL is a merge of the safest, and most importance pieces
https://codereview.chromium.org/1917333002/ to M50.

There is a race condition where an IPC::Channel can start processing messages
before it is registered as a communication channel with the attachment broker.
This CL reorders channel connection and registration.

BUG=598088, 609262
R=avi@chromium.org, mseaborn@chromium.org, tsepez@chromium.org

Committed:
https://chromium.googlesource.com/chromium/src/+/75ca2da31f0449be76215e6c4cdd...
==========

[erikchen, 2016-05-06 17:46:08]

Committed patchset #3 (id:40001) manually as
75ca2da31f0449be76215e6c4cddd371d2631e50 (presubmit successful).