Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Issue 1960483002: Include thread CPU time in Timeline (Closed)

Created:
4 years, 7 months ago by Cutch
Modified:
4 years, 7 months ago
Reviewers:
jamesr, rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Include thread CPU time in Timeline. - [x] Refactor old OSThread interface for querying thread CPU time into OS::GetCurrentThreadCPUMicros. - [x] Add data to TimelineEvent to track thread CPU time. - [x] Include "tts" and "tdur" properties when converting the timeline to JSON Fixes #26396 BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/f6b570aa2a8849a1b44831836eb115759170283e

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -91 lines) Patch
M runtime/vm/os.h View 1 chunk +7 lines, -0 lines 0 comments Download
M runtime/vm/os_android.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M runtime/vm/os_linux.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M runtime/vm/os_macos.cc View 1 1 chunk +26 lines, -0 lines 2 comments Download
M runtime/vm/os_thread.h View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/os_thread_android.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M runtime/vm/os_thread_linux.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M runtime/vm/os_thread_macos.cc View 1 chunk +0 lines, -24 lines 0 comments Download
M runtime/vm/os_thread_win.cc View 1 chunk +0 lines, -32 lines 0 comments Download
M runtime/vm/os_win.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M runtime/vm/timeline.h View 5 chunks +29 lines, -5 lines 0 comments Download
M runtime/vm/timeline.cc View 10 chunks +56 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Cutch
4 years, 7 months ago (2016-05-05 23:03:44 UTC) #3
rmacnak
lgtm
4 years, 7 months ago (2016-05-05 23:26:07 UTC) #4
Cutch
Committed patchset #2 (id:20001) manually as f6b570aa2a8849a1b44831836eb115759170283e (presubmit successful).
4 years, 7 months ago (2016-05-05 23:34:14 UTC) #6
jamesr
https://codereview.chromium.org/1960483002/diff/20001/runtime/vm/os_macos.cc File runtime/vm/os_macos.cc (right): https://codereview.chromium.org/1960483002/diff/20001/runtime/vm/os_macos.cc#newcode144 runtime/vm/os_macos.cc:144: // TODO(johnmccutchan): Implement this. No implementation exists in base. ...
4 years, 7 months ago (2016-05-09 19:52:22 UTC) #8
Cutch
4 years, 7 months ago (2016-05-09 20:38:41 UTC) #9
Message was sent while issue was closed.
https://codereview.chromium.org/1960483002/diff/20001/runtime/vm/os_macos.cc
File runtime/vm/os_macos.cc (right):

https://codereview.chromium.org/1960483002/diff/20001/runtime/vm/os_macos.cc#...
runtime/vm/os_macos.cc:144: // TODO(johnmccutchan): Implement this. No
implementation exists in base.
On 2016/05/09 19:52:22, jamesr wrote:
> FYI Chinmay investigated this function for iOS for Flutter and found that the
> Mac version works fine on modern iOS:
> 
> https://github.com/domokit/base/blob/master/time/time_mac.cc#L71

Acknowledged.

Powered by Google App Engine
This is Rietveld 408576698