Add rpcexplorer to webapp hierarchy.

Add rpcexplorer to webapp hierarchy.

BUG=

Committed: https://github.com/luci/luci-go/commit/30810888c7971fc0939089306498bf8ed9e65c7a

[dnj, 2016-05-06 19:53:50]

dnj@chromium.org changed reviewers:
+ nodir@chromium.org, vadimsh@chromium.org

[dnj, 2016-05-06 19:53:51]

PTAL. This creates a "web/" "rpcexplorer" and wires everything up to its
vulcanized output.

As per discussion, the plan after this CL is:
1) Delete bower components clones in server/static/...
2) Create a new repository, "github.com/luci/web-deps" (or something), checkout
bower/npm, commit and save.
3) DEPS that repository into "web/..." in "infra".

This will give us internal pinning.

[dnj (Google), 2016-06-13 17:58:37]

dnj@google.com changed reviewers:
+ dnj@google.com

[dnj (Google), 2016-06-13 17:58:38]

(Ping, nodir@ can you PTAL)?

[Vadim Sh., 2016-06-13 19:56:40]

https://codereview.chromium.org/1960443004/diff/1/web/README.md
File web/README.md (right):

https://codereview.chromium.org/1960443004/diff/1/web/README.md#newcode12
web/README.md:12: 1.  npm install -g bower
what about gulp?

https://codereview.chromium.org/1960443004/diff/1/web/apps/rpcexplorer/elemen...
File web/apps/rpcexplorer/elements/elements.html (right):

https://codereview.chromium.org/1960443004/diff/1/web/apps/rpcexplorer/elemen...
web/apps/rpcexplorer/elements/elements.html:2: Copyright 2015 The Chromium
Authors. All rights reserved.
we use different license now

https://codereview.chromium.org/1960443004/diff/1/web/bower.json
File web/bower.json (right):

https://codereview.chromium.org/1960443004/diff/1/web/bower.json#newcode8
web/bower.json:8: "license": "BSD",
change license and authors here too

[dnj (Google), 2016-06-13 20:51:11]

https://codereview.chromium.org/1960443004/diff/1/web/README.md
File web/README.md (right):

https://codereview.chromium.org/1960443004/diff/1/web/README.md#newcode12
web/README.md:12: 1.  npm install -g bower
On 2016/06/13 19:56:40, Vadim Sh. wrote:
> what about gulp?

Changed to running "make setup", which will install all of that.

https://codereview.chromium.org/1960443004/diff/1/web/apps/rpcexplorer/elemen...
File web/apps/rpcexplorer/elements/elements.html (right):

https://codereview.chromium.org/1960443004/diff/1/web/apps/rpcexplorer/elemen...
web/apps/rpcexplorer/elements/elements.html:2: Copyright 2015 The Chromium
Authors. All rights reserved.
On 2016/06/13 19:56:40, Vadim Sh. wrote:
> we use different license now

Ugh 1mo old CL FTW. Manually fixed :/

https://codereview.chromium.org/1960443004/diff/1/web/bower.json
File web/bower.json (right):

https://codereview.chromium.org/1960443004/diff/1/web/bower.json#newcode8
web/bower.json:8: "license": "BSD",
On 2016/06/13 19:56:40, Vadim Sh. wrote:
> change license and authors here too

Done.

[Vadim Sh., 2016-06-13 20:54:23]

lgtm as long as you have a plan how to fix all the code that uses rpcexplorer
now, and you are not going to keep it broken for too long

[nodir, 2016-06-13 21:08:09]

On 2016/06/13 20:54:23, Vadim Sh. wrote:
> lgtm as long as you have a plan how to fix all the code that uses rpcexplorer
> now, and you are not going to keep it broken for too long

specifically you are not going to keep two copies of rpc explorer for too long
lgtm

[dnj (Google), 2016-06-13 21:22:07]

On 2016/06/13 21:08:09, nodir wrote:
> On 2016/06/13 20:54:23, Vadim Sh. wrote:
> > lgtm as long as you have a plan how to fix all the code that uses
rpcexplorer
> > now, and you are not going to keep it broken for too long
> 
> specifically you are not going to keep two copies of rpc explorer for too long
> lgtm

Nothing is broken ATM, but the next steps will be to delete the old
"rpcexplorer" code and then continue with the steps in the first comment.

[dnj (Google), 2016-06-13 21:22:11]

The CQ bit was checked by dnj@google.com

[commit-bot: I haz the power, 2016-06-13 21:22:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1960443004/20001

[commit-bot: I haz the power, 2016-06-13 21:33:11]

Description was changed from

==========
Add rpcexplorer to webapp hierarchy.

BUG=
==========

to

==========
Add rpcexplorer to webapp hierarchy.

BUG=

Committed:
https://github.com/luci/luci-go/commit/30810888c7971fc0939089306498bf8ed9e65c7a
==========

[commit-bot: I haz the power, 2016-06-13 21:33:11]

Committed patchset #2 (id:20001) as
https://github.com/luci/luci-go/commit/30810888c7971fc0939089306498bf8ed9e65c7a

[Vadim Sh., 2016-06-15 23:12:38]

https://codereview.chromium.org/1960443004/diff/20001/appengine/static/common...
File appengine/static/common/rpcexplorer (right):

https://codereview.chromium.org/1960443004/diff/20001/appengine/static/common...
appengine/static/common/rpcexplorer:1: ../../../web/dist/rpcexplorer
there's no web/dist/rpcexplorer => this CL broke existing users of rpcexplorer.
Please fix soonish...

[dnj (Google), 2016-06-15 23:29:46]

On 2016/06/15 23:12:38, Vadim Sh. wrote:
>
https://codereview.chromium.org/1960443004/diff/20001/appengine/static/common...
> File appengine/static/common/rpcexplorer (right):
> 
>
https://codereview.chromium.org/1960443004/diff/20001/appengine/static/common...
> appengine/static/common/rpcexplorer:1: ../../../web/dist/rpcexplorer
> there's no web/dist/rpcexplorer => this CL broke existing users of
rpcexplorer.
> Please fix soonish...

You have to build that locally via "make" in "web/".

[Vadim Sh., 2016-06-15 23:32:50]

On 2016/06/15 23:29:46, dnj (Google) wrote:
> On 2016/06/15 23:12:38, Vadim Sh. wrote:
> >
>
https://codereview.chromium.org/1960443004/diff/20001/appengine/static/common...
> > File appengine/static/common/rpcexplorer (right):
> > 
> >
>
https://codereview.chromium.org/1960443004/diff/20001/appengine/static/common...
> > appengine/static/common/rpcexplorer:1: ../../../web/dist/rpcexplorer
> > there's no web/dist/rpcexplorer => this CL broke existing users of
> rpcexplorer.
> > Please fix soonish...
> 
> You have to build that locally via "make" in "web/".

Do I have to do it all the time? How do I know that rpcexplorer code has
changed? What about projects in infra/ and infra_internal/ that use RPC explorer
too? I thought we'll be committing build results like we do with protobuf code
:(

[dnj (Google), 2016-06-15 23:35:44]

On 2016/06/15 23:32:50, Vadim Sh. wrote:
> On 2016/06/15 23:29:46, dnj (Google) wrote:
> > On 2016/06/15 23:12:38, Vadim Sh. wrote:
> > >
> >
>
https://codereview.chromium.org/1960443004/diff/20001/appengine/static/common...
> > > File appengine/static/common/rpcexplorer (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/1960443004/diff/20001/appengine/static/common...
> > > appengine/static/common/rpcexplorer:1: ../../../web/dist/rpcexplorer
> > > there's no web/dist/rpcexplorer => this CL broke existing users of
> > rpcexplorer.
> > > Please fix soonish...
> > 
> > You have to build that locally via "make" in "web/".
> 
> Do I have to do it all the time?

Only when you want to rebuild.

> How do I know that rpcexplorer code has changed?

You don't, but no harm in rebuilding, I suppose? I should be part of deployment
process.

> What about projects in infra/ and infra_internal/ that use RPC explorer
> too?

You can "make" in LUCI repo and deploy to them, too.

> I thought we'll be committing build results like we do with protobuf code :(

We could check in "dist" if you think that's necessary. I personally feel that
checking in massive blobs of generated code is a ood way to pollute a Git object
store and make checkouts take forever, so I opted not to.

[Vadim Sh., 2016-06-16 00:34:25]

https://codereview.chromium.org/1960443004/diff/20001/appengine/static/common...
File appengine/static/common/rpcexplorer (right):

https://codereview.chromium.org/1960443004/diff/20001/appengine/static/common...
appengine/static/common/rpcexplorer:1: ../../../web/dist/rpcexplorer
On 2016/06/15 23:12:38, Vadim Sh. wrote:
> there's no web/dist/rpcexplorer => this CL broke existing users of
rpcexplorer.
> Please fix soonish...

I don't think it works as expected. Here's what ends up in web/dist/rpcexplorer
after running "make". 

Do we really have to upload all that crap? Tests and docs and demos for third
party packages...

./elements
./elements/elements.html
./inc
./inc/bower_components
./inc/bower_components/bootstrap
./inc/bower_components/bootstrap/dist
./inc/bower_components/bootstrap/dist/css
./inc/bower_components/bootstrap/dist/css/bootstrap.min.css
./inc/bower_components/platinum-sw
./inc/bower_components/platinum-sw/bootstrap
./inc/bower_components/platinum-sw/bootstrap/offline-analytics.js
./inc/bower_components/platinum-sw/bootstrap/simple-db.js
./inc/bower_components/platinum-sw/bootstrap/sw-toolbox-setup.js
./inc/bower_components/platinum-sw/bower.json
./inc/bower_components/platinum-sw/CONTRIBUTING.md
./inc/bower_components/platinum-sw/demo
./inc/bower_components/platinum-sw/demo/index.html
./inc/bower_components/platinum-sw/demo/sw-import.js
./inc/bower_components/platinum-sw/index.html
./inc/bower_components/platinum-sw/platinum-sw-cache.html
./inc/bower_components/platinum-sw/platinum-sw-elements.html
./inc/bower_components/platinum-sw/platinum-sw-fetch.html
./inc/bower_components/platinum-sw/platinum-sw-import-script.html
./inc/bower_components/platinum-sw/platinum-sw-offline-analytics.html
./inc/bower_components/platinum-sw/platinum-sw-register.html
./inc/bower_components/platinum-sw/README.md
./inc/bower_components/platinum-sw/service-worker.js
./inc/bower_components/platinum-sw/test
./inc/bower_components/platinum-sw/test/controlled-promise.js
./inc/bower_components/platinum-sw/test/index.html
./inc/bower_components/platinum-sw/test/platinum-sw-cache
./inc/bower_components/platinum-sw/test/platinum-sw-cache/cache-config.json
./inc/bower_components/platinum-sw/test/platinum-sw-cache/file.html
./inc/bower_components/platinum-sw/test/platinum-sw-cache/file.txt
./inc/bower_components/platinum-sw/test/platinum-sw-cache/index.html
./inc/bower_components/platinum-sw/test/platinum-sw-cache/listed_in_json1.txt
./inc/bower_components/platinum-sw/test/platinum-sw-cache/listed_in_json2.txt
./inc/bower_components/platinum-sw/test/platinum-sw-cache/sw-import.js
./inc/bower_components/platinum-sw/test/platinum-sw-fetch
./inc/bower_components/platinum-sw/test/platinum-sw-fetch/custom-fetch-handler.js
./inc/bower_components/platinum-sw/test/platinum-sw-fetch/index.html
./inc/bower_components/platinum-sw/test/platinum-sw-fetch/sw-import.js
./inc/bower_components/platinum-sw/test/platinum-sw-import-script
./inc/bower_components/platinum-sw/test/platinum-sw-import-script/index.html
./inc/bower_components/platinum-sw/test/platinum-sw-import-script/post-message-echo.js
./inc/bower_components/platinum-sw/test/platinum-sw-import-script/sw-import.js
./inc/bower_components/platinum-sw/test/platinum-sw-register
./inc/bower_components/platinum-sw/test/platinum-sw-register/index.html
./inc/bower_components/platinum-sw/test/platinum-sw-register/sw-import.js
./inc/bower_components/platinum-sw/test/platinum-sw-unsupported.html
./inc/bower_components/promise-polyfill
./inc/bower_components/promise-polyfill/bower.json
./inc/bower_components/promise-polyfill/Gruntfile.js
./inc/bower_components/promise-polyfill/LICENSE
./inc/bower_components/promise-polyfill/package.json
./inc/bower_components/promise-polyfill/promise-polyfill-lite.html
./inc/bower_components/promise-polyfill/promise-polyfill.html
./inc/bower_components/promise-polyfill/Promise-Statics.js
./inc/bower_components/promise-polyfill/Promise.js
./inc/bower_components/promise-polyfill/Promise.min.js
./inc/bower_components/promise-polyfill/README.md
./inc/bower_components/sw-toolbox
./inc/bower_components/sw-toolbox/bower.json
./inc/bower_components/sw-toolbox/docs
./inc/bower_components/sw-toolbox/docs/cache-expiration-options
./inc/bower_components/sw-toolbox/docs/cache-expiration-options/app.js
./inc/bower_components/sw-toolbox/docs/cache-expiration-options/index.html
./inc/bower_components/sw-toolbox/docs/cache-expiration-options/service-worker.js
./inc/bower_components/sw-toolbox/docs/cache-expiration-options/styles.css
./inc/bower_components/sw-toolbox/docs/fonts
./inc/bower_components/sw-toolbox/docs/fonts/OpenSans-Bold-webfont.eot
./inc/bower_components/sw-toolbox/docs/fonts/OpenSans-Bold-webfont.svg
./inc/bower_components/sw-toolbox/docs/fonts/OpenSans-Bold-webfont.woff
./inc/bower_components/sw-toolbox/docs/fonts/OpenSans-BoldItalic-webfont.eot
./inc/bower_components/sw-toolbox/docs/fonts/OpenSans-BoldItalic-webfont.svg
./inc/bower_components/sw-toolbox/docs/fonts/OpenSans-BoldItalic-webfont.woff
./inc/bower_components/sw-toolbox/docs/fonts/OpenSans-Italic-webfont.eot
./inc/bower_components/sw-toolbox/docs/fonts/OpenSans-Italic-webfont.svg
./inc/bower_components/sw-toolbox/docs/fonts/OpenSans-Italic-webfont.woff
./inc/bower_components/sw-toolbox/docs/fonts/OpenSans-Light-webfont.eot
./inc/bower_components/sw-toolbox/docs/fonts/OpenSans-Light-webfont.svg
./inc/bower_components/sw-toolbox/docs/fonts/OpenSans-Light-webfont.woff
./inc/bower_components/sw-toolbox/docs/fonts/OpenSans-LightItalic-webfont.eot
./inc/bower_components/sw-toolbox/docs/fonts/OpenSans-LightItalic-webfont.svg
./inc/bower_components/sw-toolbox/docs/fonts/OpenSans-LightItalic-webfont.woff
./inc/bower_components/sw-toolbox/docs/fonts/OpenSans-Regular-webfont.eot
./inc/bower_components/sw-toolbox/docs/fonts/OpenSans-Regular-webfont.svg
./inc/bower_components/sw-toolbox/docs/fonts/OpenSans-Regular-webfont.woff
./inc/bower_components/sw-toolbox/docs/index.html
./inc/bower_components/sw-toolbox/docs/scripts
./inc/bower_components/sw-toolbox/docs/scripts/linenumber.js
./inc/bower_components/sw-toolbox/docs/scripts/prettify
./inc/bower_components/sw-toolbox/docs/scripts/prettify/Apache-License-2.0.txt
./inc/bower_components/sw-toolbox/docs/scripts/prettify/lang-css.js
./inc/bower_components/sw-toolbox/docs/scripts/prettify/prettify.js
./inc/bower_components/sw-toolbox/docs/styles
./inc/bower_components/sw-toolbox/docs/styles/jsdoc-default.css
./inc/bower_components/sw-toolbox/docs/styles/prettify-jsdoc.css
./inc/bower_components/sw-toolbox/docs/styles/prettify-tomorrow.css
./inc/bower_components/sw-toolbox/docs/sw-toolbox.js
./inc/bower_components/sw-toolbox/docs/tutorial-api.html
./inc/bower_components/sw-toolbox/docs/tutorial-recipes.html
./inc/bower_components/sw-toolbox/docs/tutorial-usage.html
./inc/bower_components/sw-toolbox/LICENSE
./inc/bower_components/sw-toolbox/package.json
./inc/bower_components/sw-toolbox/README.md
./inc/bower_components/sw-toolbox/sw-toolbox.js
./inc/bower_components/sw-toolbox/sw-toolbox.map.json
./inc/bower_components/webcomponentsjs
./inc/bower_components/webcomponentsjs/bower.json
./inc/bower_components/webcomponentsjs/build.log
./inc/bower_components/webcomponentsjs/CustomElements.js
./inc/bower_components/webcomponentsjs/CustomElements.min.js
./inc/bower_components/webcomponentsjs/HTMLImports.js
./inc/bower_components/webcomponentsjs/HTMLImports.min.js
./inc/bower_components/webcomponentsjs/MutationObserver.js
./inc/bower_components/webcomponentsjs/MutationObserver.min.js
./inc/bower_components/webcomponentsjs/package.json
./inc/bower_components/webcomponentsjs/README.md
./inc/bower_components/webcomponentsjs/ShadowDOM.js
./inc/bower_components/webcomponentsjs/ShadowDOM.min.js
./inc/bower_components/webcomponentsjs/webcomponents-lite.js
./inc/bower_components/webcomponentsjs/webcomponents-lite.min.js
./inc/bower_components/webcomponentsjs/webcomponents.js
./inc/bower_components/webcomponentsjs/webcomponents.min.js
./index.html

---------

Here's logdog attempting to serve a demo page for some component it probably
even doesn't use:
https://luci-logdog.appspot.com/app/inc/bower_components/platinum-sw/demo/ind...

[dnj (Google), 2016-06-16 02:09:50]

On 2016/06/16 00:34:25, Vadim Sh. wrote:
>
https://codereview.chromium.org/1960443004/diff/20001/appengine/static/common...
> File appengine/static/common/rpcexplorer (right):
> 
>
https://codereview.chromium.org/1960443004/diff/20001/appengine/static/common...
> appengine/static/common/rpcexplorer:1: ../../../web/dist/rpcexplorer
> On 2016/06/15 23:12:38, Vadim Sh. wrote:
> > there's no web/dist/rpcexplorer => this CL broke existing users of
> rpcexplorer.
> > Please fix soonish...
> 
> I don't think it works as expected. Here's what ends up in
web/dist/rpcexplorer
> after running "make". 
> 
> Do we really have to upload all that crap? Tests and docs and demos for third
> party packages...

Probably not. ATM the logic is the same used by the Polymer team's demo app. We
can definitely prune this down to minimized files.

[nodir, 2016-06-16 23:44:14]

This broke Milo bootstrap theme
https://bugs.chromium.org/p/chromium/issues/detail?id=620911#c2

[khamidulla, 2016-06-22 03:41:13]

In latest build (https://travis-ci.org/luci/gae#L339) it gave error that it
cannot locate upload and rpcexplorer folder. When I tried in my local env under
github.com/luci/gae run following command goimports -w ./ it does not show
"/home/travis/gopath/src/github.com/luci/luci-go/web/dist/rpcexplorer: no such
file or directory " part. Error includes only
"/home/travis/gopath/src/github.com/luci/luci-go/appengine/static/common/upload:
no such file or directory".

Moreover github.com/luci/luci-go/appengine/static/common/rpcexplorer points to
./web/dist/rpcexplorer. Although it cannot locate upload folder under local env.
So link to upload is missing or not created in travis

[nodir, 2016-06-22 03:48:34]

On 2016/06/22 03:41:13, khamidulla wrote:
> In latest build (https://travis-ci.org/luci/gae#L339) it gave error that it
> cannot locate upload and rpcexplorer folder. When I tried in my local env
under
> github.com/luci/gae run following command goimports -w ./ it does not show
> "/home/travis/gopath/src/github.com/luci/luci-go/web/dist/rpcexplorer: no such
> file or directory " part. Error includes only
>
"/home/travis/gopath/src/github.com/luci/luci-go/appengine/static/common/upload:
> no such file or directory".
> 
> Moreover github.com/luci/luci-go/appengine/static/common/rpcexplorer points to
> ./web/dist/rpcexplorer. Although it cannot locate upload folder under local
env.
> So link to upload is missing or not created in travis

to be clear, this breakage sort of prevents external developers from
contribution
can we fix and/or find a workaround?

[dnj (Google), 2016-06-22 22:35:36]

On 2016/06/22 03:48:34, nodir wrote:
> On 2016/06/22 03:41:13, khamidulla wrote:
> > In latest build (https://travis-ci.org/luci/gae#L339) it gave error that it
> > cannot locate upload and rpcexplorer folder. When I tried in my local env
> under
> > github.com/luci/gae run following command goimports -w ./ it does not show
> > "/home/travis/gopath/src/github.com/luci/luci-go/web/dist/rpcexplorer: no
such
> > file or directory " part. Error includes only
> >
>
"/home/travis/gopath/src/github.com/luci/luci-go/appengine/static/common/upload:
> > no such file or directory".
> > 
> > Moreover github.com/luci/luci-go/appengine/static/common/rpcexplorer points
to
> > ./web/dist/rpcexplorer. Although it cannot locate upload folder under local
> env.
> > So link to upload is missing or not created in travis
> 
> to be clear, this breakage sort of prevents external developers from
> contribution
> can we fix and/or find a workaround?

Can you run "make" in "web/"? That's how "dist" is supposed to get populated.

[nodir, 2016-06-22 23:54:32]

On 2016/06/22 22:35:36, dnj (Google) wrote:
> On 2016/06/22 03:48:34, nodir wrote:
> > On 2016/06/22 03:41:13, khamidulla wrote:
> > > In latest build (https://travis-ci.org/luci/gae#L339) it gave error that
it
> > > cannot locate upload and rpcexplorer folder. When I tried in my local env
> > under
> > > github.com/luci/gae run following command goimports -w ./ it does not show
> > > "/home/travis/gopath/src/github.com/luci/luci-go/web/dist/rpcexplorer: no
> such
> > > file or directory " part. Error includes only
> > >
> >
>
"/home/travis/gopath/src/github.com/luci/luci-go/appengine/static/common/upload:
> > > no such file or directory".
> > > 
> > > Moreover github.com/luci/luci-go/appengine/static/common/rpcexplorer
points
> to
> > > ./web/dist/rpcexplorer. Although it cannot locate upload folder under
local
> > env.
> > > So link to upload is missing or not created in travis
> > 
> > to be clear, this breakage sort of prevents external developers from
> > contribution
> > can we fix and/or find a workaround?
> 
> Can you run "make" in "web/"? That's how "dist" is supposed to get populated.

fwiu running make under web does not restore symlink to "upload" or something
like that

[dnj (Google), 2016-06-23 02:35:23]

On 2016/06/22 23:54:32, nodir wrote:
> On 2016/06/22 22:35:36, dnj (Google) wrote:
> > On 2016/06/22 03:48:34, nodir wrote:
> > > On 2016/06/22 03:41:13, khamidulla wrote:
> > > > In latest build (https://travis-ci.org/luci/gae#L339) it gave error that
> it
> > > > cannot locate upload and rpcexplorer folder. When I tried in my local
env
> > > under
> > > > github.com/luci/gae run following command goimports -w ./ it does not
show
> > > > "/home/travis/gopath/src/github.com/luci/luci-go/web/dist/rpcexplorer:
no
> > such
> > > > file or directory " part. Error includes only
> > > >
> > >
> >
>
"/home/travis/gopath/src/github.com/luci/luci-go/appengine/static/common/upload:
> > > > no such file or directory".
> > > > 
> > > > Moreover github.com/luci/luci-go/appengine/static/common/rpcexplorer
> points
> > to
> > > > ./web/dist/rpcexplorer. Although it cannot locate upload folder under
> local
> > > env.
> > > > So link to upload is missing or not created in travis
> > > 
> > > to be clear, this breakage sort of prevents external developers from
> > > contribution
> > > can we fix and/or find a workaround?
> > 
> > Can you run "make" in "web/"? That's how "dist" is supposed to get
populated.
> 
> fwiu running make under web does not restore symlink to "upload" or something
> like that

upload should symlink to web/dist/..., which should exist the moment "make"
succeeds.