Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 1960443002: views: add PlatformStyle docs (Closed)

Created:
4 years, 7 months ago by Elly Fong-Jones
Modified:
4 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

views: add PlatformStyle docs Add advice documentation for dialog and control authors about how to use PlatformStyle. BUG= Committed: https://crrev.com/dc3cb5d2837dc71bd904f32876e5a743e6b6f1e1 Cr-Commit-Position: refs/heads/master@{#392303}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add warning about subclassing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -0 lines) Patch
A docs/ui/views/platform_style.md View 1 1 chunk +101 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Elly Fong-Jones
sky: ptal? :) These are still sort of rough and have a couple of TODOs.
4 years, 7 months ago (2016-05-05 21:32:58 UTC) #3
sky
https://codereview.chromium.org/1960443002/diff/1/docs/ui/views/platform_style.md File docs/ui/views/platform_style.md (right): https://codereview.chromium.org/1960443002/diff/1/docs/ui/views/platform_style.md#newcode67 docs/ui/views/platform_style.md:67: ### Use subclassing to add complex behavior switches Do ...
4 years, 7 months ago (2016-05-05 23:27:43 UTC) #4
Elly Fong-Jones
sky: ptal? :) https://codereview.chromium.org/1960443002/diff/1/docs/ui/views/platform_style.md File docs/ui/views/platform_style.md (right): https://codereview.chromium.org/1960443002/diff/1/docs/ui/views/platform_style.md#newcode67 docs/ui/views/platform_style.md:67: ### Use subclassing to add complex ...
4 years, 7 months ago (2016-05-06 19:23:29 UTC) #5
sky
LGTM
4 years, 7 months ago (2016-05-06 21:40:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1960443002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1960443002/20001
4 years, 7 months ago (2016-05-09 13:24:04 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-09 13:56:04 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-09 13:57:19 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dc3cb5d2837dc71bd904f32876e5a743e6b6f1e1
Cr-Commit-Position: refs/heads/master@{#392303}

Powered by Google App Engine
This is Rietveld 408576698