Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2557)

Unified Diff: chrome/browser/views/task_manager_view.cc

Issue 196040: Gtk: Allow all columns in task manager to be sortable. (Closed)
Patch Set: Delete dead code Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/gtk/task_manager_gtk.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/views/task_manager_view.cc
diff --git a/chrome/browser/views/task_manager_view.cc b/chrome/browser/views/task_manager_view.cc
index d449a92e572309279c0b28a16a82293174eb2641..b305a96e7259feabee2acb8514c1fb06dd73614c 100644
--- a/chrome/browser/views/task_manager_view.cc
+++ b/chrome/browser/views/task_manager_view.cc
@@ -33,13 +33,6 @@
static const int kDefaultWidth = 460;
static const int kDefaultHeight = 270;
-// An id for the most important column, made sufficiently large so as not to
-// collide with anything else.
-static const int64 kNuthMagicNumber = 1737350766;
-static const int kBitMask = 0x7FFFFFFF;
-static const int kGoatsTeleportedColumn =
- (94024 * kNuthMagicNumber) & kBitMask;
-
namespace {
////////////////////////////////////////////////////////////////////////////////
@@ -115,7 +108,7 @@ std::wstring TaskManagerTableModel::GetText(int row, int col_id) {
return std::wstring();
return model_->GetResourceProcessId(row);
- case kGoatsTeleportedColumn: // Goats Teleported!
+ case IDS_TASK_MANAGER_GOATS_TELEPORTED_COLUMN: // Goats Teleported!
return model_->GetResourceGoatsTeleported(row);
default:
@@ -308,13 +301,10 @@ void TaskManagerView::Init() {
tab_table_->SetColumnVisibility(IDS_TASK_MANAGER_PROCESS_ID_COLUMN, false);
tab_table_->SetColumnVisibility(IDS_TASK_MANAGER_SHARED_MEM_COLUMN, false);
tab_table_->SetColumnVisibility(IDS_TASK_MANAGER_PRIVATE_MEM_COLUMN, false);
+ tab_table_->SetColumnVisibility(IDS_TASK_MANAGER_GOATS_TELEPORTED_COLUMN,
+ false);
UpdateStatsCounters();
- TableColumn col(kGoatsTeleportedColumn, L"Goats Teleported",
- TableColumn::RIGHT, -1, 0);
- col.sortable = true;
- columns_.push_back(col);
- tab_table_->AddColumn(col);
tab_table_->SetObserver(this);
SetContextMenuController(this);
kill_button_ = new views::NativeButton(
« no previous file with comments | « chrome/browser/gtk/task_manager_gtk.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698