Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1960393002: Subzero: Add necessary PNaCl files for standalone build. (Closed)

Created:
4 years, 7 months ago by Jim Stichnoth
Modified:
4 years, 7 months ago
Reviewers:
Eric Holk, Karl, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero: Add necessary PNaCl files for standalone build. The README.txt file is new; all other files under pnacl-llvm/ are copied verbatim from the pnacl-llvm repo. BUG= none R=kschimpf@google.com Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=a5b16abfebb1d33fa4b4448f1bda1bf02cc0bd58

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove the need for NaClBitcodeMungeUtils.h #

Patch Set 3 : make format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4272 lines, -27 lines) Patch
M CMakeLists.txt View 2 chunks +18 lines, -10 lines 0 comments Download
M Makefile.standalone View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M docs/README.rst View 1 chunk +21 lines, -0 lines 0 comments Download
A pnacl-llvm/NaClBitCodes.cpp View 1 chunk +131 lines, -0 lines 0 comments Download
A pnacl-llvm/NaClBitcodeDecoders.cpp View 1 chunk +228 lines, -0 lines 0 comments Download
A pnacl-llvm/NaClBitcodeHeader.cpp View 1 chunk +351 lines, -0 lines 0 comments Download
A pnacl-llvm/NaClBitcodeParser.cpp View 1 chunk +159 lines, -0 lines 0 comments Download
A pnacl-llvm/NaClBitstreamReader.cpp View 1 chunk +444 lines, -0 lines 0 comments Download
A pnacl-llvm/README.txt View 1 chunk +9 lines, -0 lines 0 comments Download
A pnacl-llvm/include/llvm/Bitcode/NaCl/NaClBitCodes.h View 1 chunk +412 lines, -0 lines 0 comments Download
A pnacl-llvm/include/llvm/Bitcode/NaCl/NaClBitcodeDecoders.h View 1 chunk +74 lines, -0 lines 0 comments Download
A pnacl-llvm/include/llvm/Bitcode/NaCl/NaClBitcodeDefs.h View 1 chunk +53 lines, -0 lines 0 comments Download
A pnacl-llvm/include/llvm/Bitcode/NaCl/NaClBitcodeHeader.h View 1 chunk +263 lines, -0 lines 0 comments Download
A pnacl-llvm/include/llvm/Bitcode/NaCl/NaClBitcodeParser.h View 1 chunk +663 lines, -0 lines 0 comments Download
A pnacl-llvm/include/llvm/Bitcode/NaCl/NaClBitstreamReader.h View 1 chunk +911 lines, -0 lines 0 comments Download
A pnacl-llvm/include/llvm/Bitcode/NaCl/NaClLLVMBitCodes.h View 1 chunk +374 lines, -0 lines 0 comments Download
A pnacl-llvm/include/llvm/Bitcode/NaCl/NaClReaderWriter.h View 1 chunk +143 lines, -0 lines 0 comments Download
M src/IceBitVector.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/IceCompileServer.cpp View 1 2 4 chunks +7 lines, -6 lines 0 comments Download
M src/IceCompiler.cpp View 1 2 2 chunks +7 lines, -6 lines 0 comments Download
M src/IceInst.h View 1 2 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Jim Stichnoth
4 years, 7 months ago (2016-05-09 22:19:43 UTC) #3
Karl
lgtm https://codereview.chromium.org/1960393002/diff/1/pnacl-llvm/include/llvm/Bitcode/NaCl/NaClBitcodeMungeUtils.h File pnacl-llvm/include/llvm/Bitcode/NaCl/NaClBitcodeMungeUtils.h (right): https://codereview.chromium.org/1960393002/diff/1/pnacl-llvm/include/llvm/Bitcode/NaCl/NaClBitcodeMungeUtils.h#newcode72 pnacl-llvm/include/llvm/Bitcode/NaCl/NaClBitcodeMungeUtils.h:72: // ===---------------------------------------------------------------------===// Is this file really needed? It ...
4 years, 7 months ago (2016-05-10 14:49:48 UTC) #4
Jim Stichnoth
https://codereview.chromium.org/1960393002/diff/1/pnacl-llvm/include/llvm/Bitcode/NaCl/NaClBitcodeMungeUtils.h File pnacl-llvm/include/llvm/Bitcode/NaCl/NaClBitcodeMungeUtils.h (right): https://codereview.chromium.org/1960393002/diff/1/pnacl-llvm/include/llvm/Bitcode/NaCl/NaClBitcodeMungeUtils.h#newcode72 pnacl-llvm/include/llvm/Bitcode/NaCl/NaClBitcodeMungeUtils.h:72: // ===---------------------------------------------------------------------===// On 2016/05/10 14:49:48, Karl wrote: > Is ...
4 years, 7 months ago (2016-05-10 18:11:48 UTC) #5
Jim Stichnoth
4 years, 7 months ago (2016-05-10 18:20:46 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
a5b16abfebb1d33fa4b4448f1bda1bf02cc0bd58 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698