third_party/WebKit/Source/devtools/front_end/animation/AnimationTimeline.js - Issue 1960373003: DevTools: follow up to r392483, do not run animation groups when paused.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/animation/AnimationTimeline.js

Issue 1960373003: DevTools: follow up to r392483, do not run animation groups when paused. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/devtools/front_end/animation/AnimationTimeline.js

diff --git a/third_party/WebKit/Source/devtools/front_end/animation/AnimationTimeline.js b/third_party/WebKit/Source/devtools/front_end/animation/AnimationTimeline.js

index bee6331fd55b822fbc30532bb567c64bfa4b2d7a..9c0e9df8ec76a335b414471360875e8123721e3f 100644

--- a/third_party/WebKit/Source/devtools/front_end/animation/AnimationTimeline.js

+++ b/third_party/WebKit/Source/devtools/front_end/animation/AnimationTimeline.js

@@ -265,7 +265,7 @@ WebInspector.AnimationTimeline.prototype = {

_effectivePlaybackRate: function()

{

- return this._selectedGroup && this._selectedGroup.paused() ? 0 : this._playbackRate;

+ return this._selectedGroup && this._selectedGroup.paused() ? 0 : (this._allPaused ? 0 : this._playbackRate);

samli 2016/05/10 00:55:21 Nit: remove chained ternary (this._selectedGroup

/**

« no previous file with comments | « no previous file | no next file » | no next file with comments »