DevTools: follow up to r392483, do not run animation groups when paused.

DevTools: follow up to r392483, do not run animation groups when paused.

BUG=608073
Committed: https://crrev.com/e8a797d9c607f364f10a6f628fbe4fb4ec408def
Cr-Commit-Position: refs/heads/master@{#392532}

[pfeldman, 2016-05-10 00:49:21]

pfeldman@chromium.org changed reviewers:
+ samli@chromium.org

[samli, 2016-05-10 00:55:21]

lgtm, I think this fixes it.

Still concerned this has multiple pause states.

https://codereview.chromium.org/1960373003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/animation/AnimationTimeline.js
(right):

https://codereview.chromium.org/1960373003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/animation/AnimationTimeline.js:268:
return this._selectedGroup && this._selectedGroup.paused() ? 0 :
(this._allPaused ? 0 : this._playbackRate);
Nit: remove chained ternary

(this._selectedGroup && this._selectedGroup.paused()) || this._allPaused ? 0 :
this._playbackRate;

[pfeldman, 2016-05-10 01:30:59]

On 2016/05/10 00:55:21, samli wrote:
> lgtm, I think this fixes it.
> 
> Still concerned this has multiple pause states.
> 
>
https://codereview.chromium.org/1960373003/diff/1/third_party/WebKit/Source/d...
> File
third_party/WebKit/Source/devtools/front_end/animation/AnimationTimeline.js
> (right):
> 
>
https://codereview.chromium.org/1960373003/diff/1/third_party/WebKit/Source/d...
>
third_party/WebKit/Source/devtools/front_end/animation/AnimationTimeline.js:268:
> return this._selectedGroup && this._selectedGroup.paused() ? 0 :
> (this._allPaused ? 0 : this._playbackRate);
> Nit: remove chained ternary
> 
> (this._selectedGroup && this._selectedGroup.paused()) || this._allPaused ? 0 :
> this._playbackRate;

Done.

[pfeldman, 2016-05-10 01:36:21]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2016-05-10 01:36:21]

The patchset sent to the CQ was uploaded after l-g-t-m from samli@chromium.org
Link to the patchset: https://codereview.chromium.org/1960373003/#ps20001
(title: "comment addressed")

[commit-bot: I haz the power, 2016-05-10 01:36:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1960373003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1960373003/20001

[commit-bot: I haz the power, 2016-05-10 02:58:42]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-10 03:00:05]

Description was changed from

==========
DevTools: follow up to r392483, do not run animation groups when paused.

BUG=608073
==========

to

==========
DevTools: follow up to r392483, do not run animation groups when paused.

BUG=608073

Committed: https://crrev.com/e8a797d9c607f364f10a6f628fbe4fb4ec408def
Cr-Commit-Position: refs/heads/master@{#392532}
==========

[commit-bot: I haz the power, 2016-05-10 03:00:07]

Patchset 2 (id:??) landed as
https://crrev.com/e8a797d9c607f364f10a6f628fbe4fb4ec408def
Cr-Commit-Position: refs/heads/master@{#392532}