Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 1960373002: nodeAtPoint(): Perform the early-check EARLY. (Closed)

Created:
4 years, 7 months ago by mstensho (USE GERRIT)
Modified:
4 years, 7 months ago
Reviewers:
eae, szager1, wkorman
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

nodeAtPoint(): Perform the early-check EARLY. Hit-testing overflow controls before checking if we need to do anything at all affected performance, so just remove the LayoutBlock override for nodeAtPoint() and hit test overflow controls there, but do so AFTER we have made sure that the point is within bounds. Fixes 15% performance regression for PerformanceTests/Events/hit-test-lots-of-layers.html BUG=610250 Committed: https://crrev.com/4f8e71034d840043dcf49bb51e8f911ec284f709 Cr-Commit-Position: refs/heads/master@{#392626}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -11 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBlock.h View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlock.cpp View 1 chunk +4 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
mstensho (USE GERRIT)
4 years, 7 months ago (2016-05-10 07:27:17 UTC) #2
eae
LGTM
4 years, 7 months ago (2016-05-10 15:33:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1960373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1960373002/1
4 years, 7 months ago (2016-05-10 15:33:55 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-10 16:44:33 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-10 16:45:51 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4f8e71034d840043dcf49bb51e8f911ec284f709
Cr-Commit-Position: refs/heads/master@{#392626}

Powered by Google App Engine
This is Rietveld 408576698